-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Footer): add Footer, EnrichedLink and LangSwitch components #2
Conversation
@@ -74,6 +74,11 @@ task('styles-global', () => { | |||
|
|||
task('styles-components', () => { | |||
return src([`src/**/*.scss`, `!src/**/__stories__/**/*.scss`, '!src/widget/**/*.scss']) | |||
.pipe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reason for the build problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coold you just include to src node_modules/@gravity-ui/page-constructor/styles/*.scss
or it wouldn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't work
d3d7657
to
565acad
Compare
@@ -74,6 +74,11 @@ task('styles-global', () => { | |||
|
|||
task('styles-components', () => { | |||
return src([`src/**/*.scss`, `!src/**/__stories__/**/*.scss`, '!src/widget/**/*.scss']) | |||
.pipe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coold you just include to src node_modules/@gravity-ui/page-constructor/styles/*.scss
or it wouldn't work?
const SOCIAL_ICON_SIZE = 24; | ||
|
||
export interface EnrichedLinkProps extends ClassNameProps { | ||
// Text of link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comments are redundant
onClick, | ||
}; | ||
|
||
if (noreferrer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add it anyway if we got blank===true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
} | ||
|
||
export interface GroupLinkColumn { | ||
// Title for column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same about comments
src/components/Footer/types.ts
Outdated
@@ -0,0 +1,37 @@ | |||
import type {ClassNameProps} from '@gravity-ui/page-constructor'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we rename file to models.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/components/Footer/variables.scss
Outdated
@@ -0,0 +1,5 @@ | |||
$footerMarginXS: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessary now, but I think It would be better to switch to css native variables completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/components/Footer/models.ts
Outdated
rightItems?: EnrichedLinkProps[]; | ||
// Copyright text | ||
copyright?: string; | ||
// Params for lang switch component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of this comments are redundant
src/components/Footer/models.ts
Outdated
export type FooterType = 'simple' | 'default'; | ||
|
||
export type FooterMedia = { | ||
// What we want to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of this comments are redundant
No description provided.