feat(Footer): add Footer, EnrichedLink and LangSwitch components #2
Conversation
| @@ -74,6 +74,11 @@ task('styles-global', () => { | |||
|
|
|||
| task('styles-components', () => { | |||
| return src([`src/**/*.scss`, `!src/**/__stories__/**/*.scss`, '!src/widget/**/*.scss']) | |||
| .pipe( | |||
There was a problem hiding this comment.
This is the reason for the build problem.
There was a problem hiding this comment.
coold you just include to src node_modules/@gravity-ui/page-constructor/styles/*.scss or it wouldn't work?
Lakate
force-pushed
the
feat/footer
branch
2 times, most recently
from
d3d7657
to
565acad
Compare
| @@ -74,6 +74,11 @@ task('styles-global', () => { | |||
|
|
|||
| task('styles-components', () => { | |||
| return src([`src/**/*.scss`, `!src/**/__stories__/**/*.scss`, '!src/widget/**/*.scss']) | |||
| .pipe( | |||
There was a problem hiding this comment.
coold you just include to src node_modules/@gravity-ui/page-constructor/styles/*.scss or it wouldn't work?
| const SOCIAL_ICON_SIZE = 24; | ||
|
|
||
| export interface EnrichedLinkProps extends ClassNameProps { | ||
| // Text of link |
There was a problem hiding this comment.
I think this comments are redundant
| onClick, | ||
| }; | ||
|
|
||
| if (noreferrer) { |
There was a problem hiding this comment.
I think we should add it anyway if we got blank===true
| } | ||
|
|
||
| export interface GroupLinkColumn { | ||
| // Title for column |
src/components/Footer/types.ts
Outdated
| @@ -0,0 +1,37 @@ | |||
| import type {ClassNameProps} from '@gravity-ui/page-constructor'; | |||
There was a problem hiding this comment.
could we rename file to models.ts?
src/components/Footer/variables.scss
Outdated
| @@ -0,0 +1,5 @@ | |||
| $footerMarginXS: 12px; | |||
There was a problem hiding this comment.
not necessary now, but I think It would be better to switch to css native variables completely
src/components/Footer/models.ts
Outdated
| rightItems?: EnrichedLinkProps[]; | ||
| // Copyright text | ||
| copyright?: string; | ||
| // Params for lang switch component |
There was a problem hiding this comment.
I think all of this comments are redundant
src/components/Footer/models.ts
Outdated
| export type FooterType = 'simple' | 'default'; | ||
|
|
||
| export type FooterMedia = { | ||
| // What we want to show |
There was a problem hiding this comment.
I think all of this comments are redundant
No description provided.