Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for playground=sandpit #3884

Closed
carstenhag opened this issue Sep 12, 2019 · 8 comments
Closed

Add rendering for playground=sandpit #3884

carstenhag opened this issue Sep 12, 2019 · 8 comments
Labels
declined new features Requests to render new features POI

Comments

@carstenhag
Copy link

Expected behavior

Sandpit area renders a bright brownish area

Actual behavior

It doesn't show up at all.

Links and screenshots illustrating the problem

https://www.openstreetmap.org/edit#map=19/48.27879/10.97427

https://www.openstreetmap.org/way/721297176

@carstenhag carstenhag changed the title Add rendering for sandpit Add rendering for playground=sandpit Sep 12, 2019
@polarbearing
Copy link
Contributor

Related to the request in #3885, in #3230 rendering sandpit as sand was rejected.

@carstenhag
Copy link
Author

#3230 was closed because the author does not continue to work on it, as far as I understood the close notice?

Even if playground equip is not rendered as >icons<, I find it silly that table tennis does render but a big sandpit isn't.

@polarbearing
Copy link
Contributor

How is table tennis rendered??

@carstenhag
Copy link
Author

It's just beneath the sandpit. Bottom left on my crappy screenshot:

Screenshot_20190912-230008

@polarbearing
Copy link
Contributor

It is leisure=pitch that renders here, not sport=table_tennis.

@Adamant36
Copy link
Contributor

Could just render it as a yellow area or something similar that shows it's there but not give it the sand pattern. Of course rendering sandpits shouldn't be done in isolation of the broader question of rendering other playground equipment IMHO.

@jeisenbe jeisenbe added the new features Requests to render new features label Sep 13, 2019
@jeisenbe
Copy link
Collaborator

PR #3230 was specifically about rendering playground=sandpit the same as natural=sand - this was not considered a good idea, because sand boxes in playground are quite different in purpose and function than most areas of sand which are tagged natural=sand

Do you have a different idea for rendering these features?

Consider that beach volleyball courts, with a sand surface, are rendered the same as concrete
basketball courts and grass soccer pitches - we render by function and purpose, not by surface type.

As with golf=bunker which goes along with other golf= features, playground=sandpit would need to be rendered along with other playground= features.

This may prove difficult; a PR was previously attempted, but it was hard to find a generic playground icon to replace the current see-saw icon, which looks like a specific equipment type: #3161

@matkoniecz
Copy link
Contributor

Closing due to no reply to

Do you have a different idea for rendering these features?

I am not fundamentally opposed to idea of rendering this structure but I am very, very, very dubious about adding yet another new icon and even more dubious that there is some reasonable area rendering.

And missing sandpits are not a major issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

5 participants