Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for playground=structure #3885

Closed
carstenhag opened this issue Sep 12, 2019 · 13 comments
Closed

Add rendering for playground=structure #3885

carstenhag opened this issue Sep 12, 2019 · 13 comments
Labels
declined new features Requests to render new features POI

Comments

@carstenhag
Copy link

Expected behavior

Structures get rendered. They should not be transparent.

Actual behavior

"Structure" playgrounds don't get rendered :(

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/721297178
https://www.openstreetmap.org/way/721297179

@polarbearing
Copy link
Contributor

Actually playground=structure does not mean a particular type of playground, it is one of the typical playground devices. Among them are swings, see-saws, sandpits etc.

None of this playground equipment is currently rendered in this style. I would not expect them to be shown here in a general map.

Recently somebody created a map that shows them, have a look here : https://wiki.openstreetmap.org/wiki/Babykarte

@polarbearing
Copy link
Contributor

In #3161 it was decided not not render playground equipment.

@jeisenbe jeisenbe added the new features Requests to render new features label Sep 12, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Sep 12, 2019

@carstenhag are you only interested in playground=structure, or should this issue be expanded to include other types of playground=* equipment like see-saws, swings, slides, etc?

Note that using different icons for each type of playground= equipment was in PR #3161 which was also closed. Do you have a different idea for rendering these features?

@carstenhag
Copy link
Author

Well, to me it would make sense to at least show "something". I'm not sure if 20 icons on one playground are the best way.

Nothing being shown just seems wrong.

@jeisenbe
Copy link
Collaborator

Normally a playground is tagged with leisure=playground. The two examples above, https://www.openstreetmap.org/way/721297178 and https://www.openstreetmap.org/way/721297179, only have playground=structure, but that tag is not meant to be used without a surrounding area tagged with leisure=playground - or you can add leisure=playground to the same object as playground=structure, if that's the whole extent of the playground.

See https://wiki.openstreetmap.org/wiki/Tag:playground=structure - note:
"useful combination: leisure=playground for the area around the devices"

@carstenhag
Copy link
Author

Well... https://www.openstreetmap.org/way/315040636 is the surrounding area with leisure=playground. I don't know what you are wanting to tell me :)

@jeisenbe
Copy link
Collaborator

Sorry, I misinterpreted your comment about "it would make sense to at least show something".

Do you have a thought about a way that these features could be shown, besides using different icons for each type?

@polarbearing
Copy link
Contributor

While leisure=playground is indeed a useful combination for the surroundings of a device in most cases, in reality you have sometimes stray devices e.g. in a park, without defining a playground. A swing here, a springy there.

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 13, 2019

in reality you have sometimes stray devices e.g. in a park, without defining a playground. A swing here, a springy there.

In my tagging, and also in my experience such places can be treated and mapped as a very small playgrounds. Is it something that is considered as poor tagging/incorrect? If yes - is it documented/discussed somewhere?

@polarbearing
Copy link
Contributor

I would not consider that a suitable solution. If I ask a query tool, how many playgrounds are in this area, the number would be significantly inflated by such 'micro-playgrounds'. Further, they have not a verifiable boundary. This probably needs further discussion and documentation.

@jeisenbe
Copy link
Collaborator

they have not a verifiable boundary.

In that case mapping as a node is a good solution.

@jeisenbe
Copy link
Collaborator

I think we should probably close this issue, since #3161 attempted to render playground equipment but it was not possible to find 14 pixel icons that could work for all the features or a generic playground icon that did not look like a see-saw. However, if someone has new ideas about how to render these features in an appropriate way, we could reconsider.

@polarbearing
Copy link
Contributor

Happy enough to close, it is a case for a specialized map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

4 participants