Add playground equipment rendering #3161
Conversation
|
The svgs should be exported so they dont have all inkscape metadata anymore. But most important we have to decide if we want to render this high detail in this general purpose style |
|
Interesting work, especially for z19+. My comments:
|
|
One more thing - it's good to join paths in the image, see: https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#map-icon-guidelines |
|
|
What do you mean by joining the paths? Also: yes: I do think we should render this. It shows the richness and possibilities of OSM, and I would love to fill the playgrounds with more details. |
|
Path > Combine probably. |
|
I'm against - it's creating too much mess and I don't see a need for details of playgrounds. |
|
- It is only shown on the highest zoom level (19) to avoid the mess
- This detail has an added value, for showing the richness. And I like very
much to see what a playground has to offer beforehand. And it will
stimulate the better mapping of playgrounds as well.
Met vriendelijke groeten,
Pieter Vander Vennet
2018-04-01 20:34 GMT+02:00 Tomasz Wójcik <notifications@github.com>:
… I'm against - it's creating too much mess and I don't see a need for
details of playgrounds.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZgbo5FbsBFlDiyE-AOeJDC4NY9TCtjks5tkR3DgaJpZM4TCzfe>
.
|
|
Some feedback on the icons:
|
|
I don't believe it creates mess. If you go down to the playground and zoom in to z19 it's hard for me to believe that it was by accident and you don't want to see the details other than just the leisure background color all around. The mess is when some features can be found in different places, like wayside shrine for example - beside being useful outdoor landmark it can be found in the city where once upon the time was the old way and now it's crowded place. That's why we had to tune zoom level to avoid mess while trying to show them relatively early for the more typical cases. Playground equipment is just a detail of a playground and this is where it can be found, so it's natural to expect it here - but of course on later zoom level than the playground as a whole. Z19 is very safe choice in that respect. |
|
Could someone render this dense mapped playground? |
|
I will have a look at the icons in a few days, when more people had the chance to comment on them. I'll try to fix all issues at once then. @HolgerJeromin : The difference is small, as play_structure is not rendered. It's difficult to make an icon for that.
|
There was a problem hiding this comment.
I don't believe these icons are worth adding. Their benefit for finding something by looking at the map or orienting yourself when there in person are minimal, nor are there are special considerations which make playground equipment cartographically significant.
|
sent from a phone
On 8. Apr 2018, at 09:12, Paul Norman ***@***.***> wrote:
nor are there are special considerations which make playground equipment cartographically significant.
you simply don’t seem to have kids. Significance is always relative, clearly the equipment is not super relevant on a city scale, but it could be a nice gimmick when zoomed in (18/19)
|
|
Aside from the issues with the idea in general, the SVGs do meet our map icon style guidelines for canvas size, SVG XML formatting, and likely pixel alignment and reduced complexity. |
It strongly depends on which scale we're talking about. It's absolutely unsignificant (and I would call it just wrong) on a country or city level. Yet there are many detailed plans for such places on a high zoom level, for example: Someone took the time to tag these objects, so she thinks it's important enough and I understand very well why micromapping is important for people.
Complexity is not that big in presented icons and pixel alignment is not top priority for everything other than simple geometrical shapes, but size doesn't look like 14 px in all the cases and it looks like a different style currently - BTW, are these icons yours or taken from some other style (I want to be sure the license is proper for us to use them)? |
|
Hello everyone, Yes, this is meant to be a fun gimmick for families, on high zoom level (only 19 ATM). I will look at the icons once more in a few days, when everyone has given his opinion. I designed them myself (although one piece came from a CC0-image). |
|
@pnorman: did you mean "the SVGs do not meet our map icon style guidelines" ? None of the icons works in 14px. @pietervdvn - sorry but your concept does not work here, for me. The existing 'playground' icon cites a typical equipment, the see-saw. We would need to find an equipment-agnostic icon for 'playground' if we started rendering specific equipment. These equipment icons would need to cite the general playground icon, so the viewer could recognise the relation between them. Even if that could be solved, the problem would be that you could not recognise the playground because there are too many equipment icons. Like not finding the wood because there are too many trees.
If you refer to the Bikeshedding in a sense that we are nitpicking on unnecessary details, your criticism is inappropriate. If everybody would throw her own design in the field, we would not recognise anything anymore. Imagine a soccer team with everybody wearing their own dress.
Indeed it would be fabulous on a family or kids oriented map style. Don't get me wrong. I contributed a lot to the wiki page and map every swing I find. But this is the general style. |
This is a vaild problem and thanks for noticing it, but we have it with other types of objects. Do you recognize park with fountains, artworks, buildings, footways, waterways, ponds, lawns, trees, playgrounds etc? I do, because usually they are rendered later than park. The only bad situation is when objects belonging to something bigger are visible too early. I have no idea how to move cemetery alleys/footpaths to higher zoom levels. Also well mapped hospitals or schools are no longer seen as yellow areas. The same with shops inside marketplace. See #2896. With playground objects we have no such problems. We see playgrounds from z17 as icon and even earlier as an area. The area is still visible on z19, so you won't forget what are you zooming in. |
|
I admit that I have (again) doubts whatever it is too much or is it still OK to render such details. I had similar doubts about rubbish bin and benches. |
|
I would like to hear some arguments about source of these doubts, especially when these objects are rendered only on highest level. Maybe there will be nothing new, but still it's interesting for me to try to understand it. I have other doubts - IMO it will be hard to just "rescale" these icons to 14 px. |
|
sent from a phone
On 11. Apr 2018, at 19:23, Mateusz Konieczny ***@***.***> wrote:
I admit that I have (again) doubts whatever it is too much or is it still OK to render such details.
It would be nice to show actual geometries of the things (playground castles, slides, ...
slides can be huge (generally they aren’t): https://goo.gl/images/xzxCAe
|
|
sent from a phone
On 11. Apr 2018, at 21:24, kocio-pl ***@***.***> wrote:
I would like to hear some arguments about source of these doubts, especially when these objects are rendered only on highest level
if it’s rendered as symbol it could lead to “cluttered heaps of icons”, as there are typically many “features” in a small space on playgrounds.
|
|
The main problem i see is from polarbearing: first scenario: playground without second scenario: playground with only one second option: |
|
@polarbearing @HolgerJeromin The only 'perfect' option I currently see is a new icon for playgrounds which does not feature a playground equipment icon (e.g. a kid running as seen with fitnesses icons or something similar), although I do not have a very good idea for that and I'm not willing to pick up that battle. IMHO, showing the seesaw at high zoom levels is not perfect, but not a big issue. I'd rather have a map which shows icons and one to much, then having no icons as well. However, hiding the seesaw-icon at high zoom levels is problematic. A playground without playground equipment would suddenly lose all icons. For now, I would let the seesaw in place, even if no seesaw is present. On the other criticisms: as they icons render only on Z19, I don't think the cluttering of the map will pose any problem. I'm having a look to the icons again to make them 14px. And yes, rendering playground outlines would be great, but I'll only be trying that if this icon set goes somewhere. |
|
Assuming that there was a nice 14x14 icon for each type of equipment, and each of these icons could be interpreted as a playground at lower zoom levels (may be a big assumption), then perhaps we could use the seesaw icon if no other equipment is tagged, or if equipment is tagged, just pick one and use that as the playground icon for that playground on all zoom levels. |
Same with airport or cities :-) We had an generic icon proposal (for kindergarten) in #120 (comment) which could be used in leisure color for playgrounds. |
There was a problem hiding this comment.
Thanks for putting a lot of effort into this. I'm with @pnorman here in thinking that this is too much detail even for z19. It is always hard having to be against a change especially from a first-time contributor who took up the hassle and get into contributing here.
|
Since there are few voices against having this feature at all and I think it would be hard even for a skilled graphic designer to make the icons 14 px, I will close this ticket without merging. Sorry, I hope next time you will have more luck. However i was talking lately with @dotevo and he said he was trying to create special app exactly for showing playground equipment, so you could talk with him about that. |
|
Ohh... I like this idea :-/ It is very useful for parents. I think the benches look bolder than this. |
|
@pietervdvn I'd be happy to take a pull request at https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/ for symbols to show at zoom 20 and above (that style is designed for around up to zoom 24), but the graphics would still need to look characteristic even when rendered in 14x14 pixels - something that would be tricky with e.g. https://github.com/pietervdvn/openstreetmap-carto/blob/60cdab62b8696ce8d550897a16d078df9a8c2e7e/symbols/playground/swing.svg as it stands. |
|
I appreciate all the feedback and its a bit sad that the PR didn't go
through. For now, I do not have the time to follow this up or to redesign
the icons; but perhaps one day I might retry of send a PR to SomeoneElseOSM.
Bye everyone, I'm sure we'll meet again someday soon!
Met vriendelijke groeten,
Pieter Vander Vennet
2018-04-27 23:27 GMT+02:00 SomeoneElseOSM <notifications@github.com>:
… @pietervdvn <https://github.com/pietervdvn> I'd be happy to take a pull
request at https://github.com/SomeoneElseOSM/openstreetmap-carto-AJT/ for
symbols to show at zoom 20 and above (that style is designed for around up
to zoom 24), but the graphics would still need to look characteristic even
when rendered in 14x14 pixels - something that would be tricky with e.g.
https://github.com/pietervdvn/openstreetmap-carto/blob/
60cdab6/symbols/playground/swing.svg as
it stands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZgbgTTySdk3cdl9asHF7h7NeZ1Pncaks5ts404gaJpZM4TCzfe>
.
|
|
I don't see how this would be bad for the highest possible zoom level. The user just sees a green area if we don't render playground equips on playgrounds. |
|
Could someone start working on this? It would be much appricaited. |
|
There are specialised maps now that render these features. I doubt it is useful on the general style. |
|
What are the specialized maps that render this? Got links? (edited to add: sadly, https://taginfo.openstreetmap.org/tags/playground=swing#projects -- does not list any specialized maps. @polarbearing -- which ones were you referring to?) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I was not aware of distinction between playground-items. The latter is what I missed in a park, in issue #4816. I would be happy if it was just those 2 possibilities, not going into further (too much) detail. |
Changes proposed in this pull request:
Test rendering with links to the example places:
See https://www.openstreetmap.org/#map=19/51.20569/3.23290
Before:
After
