Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using variables for colors #58

Merged
merged 3 commits into from Sep 4, 2013

Conversation

ian29
Copy link
Contributor

@ian29 ian29 commented Jun 10, 2013

I've only started on this for the colors present in landcovers.mss, but it will unlock tasks like #56 and #57 (or at least make them much much easier to implement)

I also recognize that this is somewhat against the spirit of this bit from the README:

Care will be taken to not get too clever with variables and expressions. While these often make it easier to customise, experience has shown that over-cleverness (e.g. interpolated entities) can discourage contributions.

While I don't want to discourage contributions, I think making the style more structured + logical is important. Keeping consistent colors across thematic features will be important for making the map design flatter and more legible as we progress on Version 3 improvements.

All that being said, I'd love to hear reasons why this is might hurt contributions.

@gravitystorm gravitystorm merged commit adbfc10 into gravitystorm:master Sep 4, 2013
@gravitystorm
Copy link
Owner

Apologies for taking so long to review, update and merge this! Thanks for the work.

@ian29
Copy link
Contributor Author

ian29 commented Sep 4, 2013

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants