Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-character shields uncentered #680

Closed
pnorman opened this issue Jun 30, 2014 · 4 comments · Fixed by #694
Closed

Single-character shields uncentered #680

pnorman opened this issue Jun 30, 2014 · 4 comments · Fixed by #694
Assignees

Comments

@pnorman
Copy link
Collaborator

pnorman commented Jun 30, 2014

Most obvious with X, but also true with "1", the most common single-character ref.

image
http://www.openstreetmap.org/#map=17/36.84028/10.21406

@pnorman pnorman added the bug label Jun 30, 2014
@pnorman pnorman self-assigned this Jun 30, 2014
@gravitystorm
Copy link
Owner

I suspect this is a mapnik issue, but it could be worth checking that there's nothing daft with our shield icons first.

See e.g. http://gis.19327.n5.nabble.com/text-placement-bug-in-shieldsymbolizer-td5339352.html

@pnorman
Copy link
Collaborator Author

pnorman commented Jun 30, 2014

I fiddled with shield placement for several hours (https://twitter.com/penorman/status/483406400236707840) when writing SVG shields. I have a fix which involves shifting the shields in the SVG by about 1.5 pixels.

It also turns out that this bug is also present for all shields, not just one-character shields.

Is there something daft? Probably, I can't get a simple 2px circle to place in the middle of the text by adjusting any of the stylesheet shield parameters. In all honesty, after spending 6 hours staring at shields, what I have is "good enough".

@dieterdreist
Copy link

2014-06-30 20:22 GMT+02:00 Paul Norman notifications@github.com:

Is there something daft? Probably, I can't get a simple 2px circle to
place in the middle of the text by adjusting any of the stylesheet
shield parameters.

IIRR there is a bug in mapnik regarding shields and their text placement
(also vertically it used to be inconsistently placed).

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 2, 2014

also vertically it used to be inconsistently placed

Yes, I had to adjust both directions, and by different amounts

pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue Jul 3, 2014
Fixes gravitystorm#680
Fixes gravitystorm#203
Fixes gravitystorm#202 (mostly)
Fixes gravitystorm#146 (mostly)

Cross-reference gravitystorm#294 mapnik/mapnik#2020

Starts organization for gravitystorm#508

Replace existing PNG road shields with new SVG ones. This allows for easier adjustment of colour and width as well as sharper high-resolution rendering.

At the same time, a number of other shield related bugs are fixed.

To aid in organization, a new shields directory is created.
pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue Jul 3, 2014
Fixes gravitystorm#680
Fixes gravitystorm#203
Fixes gravitystorm#202 (mostly)
Fixes gravitystorm#146 (mostly)

Cross-reference gravitystorm#294 mapnik/mapnik#2020

Starts organization for gravitystorm#508

Replace existing PNG road shields with new SVG ones. This allows for easier adjustment of colour and width as well as sharper high-resolution rendering.

At the same time, a number of other shield related bugs are fixed.

To aid in organization, a new shields directory is created.
pnorman added a commit to pnorman/openstreetmap-carto that referenced this issue Jul 3, 2014
Fixes gravitystorm#693
Fixes gravitystorm#680
Fixes gravitystorm#203
Fixes gravitystorm#202 (mostly)
Fixes gravitystorm#146 (mostly)

Cross-reference gravitystorm#294 mapnik/mapnik#2020

Starts organization for gravitystorm#508

Replace existing PNG road shields with new SVG ones. This allows for easier adjustment of colour and width as well as sharper high-resolution rendering.

At the same time, a number of other shield related bugs are fixed.

To aid in organization, a new shields directory is created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants