Add icon for amenity=bench and amenity=waste_basket

[matthijsmelissen]

• Add icon for amenity=bench from z18 (resolves Add rendering for amenity=bench #194)
• Add icon for amenity=waste_basket from z19 (resolves Add rendering for amenity=waste_basket #418)

These icons are taken from the SJJB repository, so they are still not aligned to the pixels.

Preview:

[HolgerJeromin]

At least the bench should be included direct as SVG.

[floscher]

At least the bench should be included direct as SVG.

👍, I've opened pull request matthijsmelissen#5 for this.

[nebulon42]

As with #1240 for picnic table I'm not sure if the bench should be slightly thicker? With 1.5px thickness it would look like that (more blurry of course):

(bench-16.svg)

[pnorman]

I prefer 1.5 pixels

[nebulon42]

This would be my proposal for waste basket (waste-basket-16.svg):

[matthijsmelissen]

I merged in the svg bench icon.

I don't particularly like the bin icon - not sure what to do about it, maybe it would look better with a straight bottom?

[nebulon42]

Maybe this:

[matkoniecz]

@nebulon42 - I like this icon.

[matthijsmelissen]

Yes, looks better to me. Thanks!

[nebulon42]

I have updated the corresponding icon: waste-basket-16.svg

[matthijsmelissen]

I updated the PR with both svg icons.

[nebulon42]

To me bench.16.svg is still displayed as 1px version. Did you mean to keep that?

[matthijsmelissen]

Did you mean to keep that?

No I forgot that one, it should be updated now. I also updated the preview.

[HolgerJeromin]

A bench is larger than a basket. They are often near. It looks strange if the basket has more visual weight.

[nebulon42]

Normally, I'd like to use every pixel of the restricted 16px frame for the icon, but I agree in a way. I have reduced the profile of the waste basket a bit:

I like the low profile of the bench. An option would be to add a back-rest to it as is done in the Humanitarian style, but I'm not too fond of that.

[daganzdaanda]

The new waste basket looks good to me.
I'm happy that benches and baskets will appear on the map soon!
But let's not forget that some benches are tagged on lines. (See also #194 (comment) ) I would like to see those, too, but I have no good idea. Just a fat grey line, maybe with the symbol in the middle?

[HolgerJeromin]

Yes. I would show the Icon for benches as ways, too. But showing the dimension seems not easy possible, so drop this information.

[matthijsmelissen]

How should we do that? Does it make sense to add an extra query specifically for linear benches?

[matthijsmelissen]

Added new bin icon and updated preview.

[matkoniecz]

Maybe bin icon can be even smaller?

[matthijsmelissen]

I'd prefer to leave the icon as is.

[matkoniecz]

I propose moving these two icons to .amenity-low-priority to avoid blocking more important icons and labels.

[althio]

The guidance #1282 (comment) about icon size and weight is IMO very applicable here. As mentioned earlier #1249 (comment) weight of bin vs bench is strange.

We do not have practical guidelines yet, just general guidance.
This present issue on bench / bin can be a useful practical case to determine size / weight / priority / tiers of icons. First in a 'fight' bench vs bin, and also as in bench&bin vs other icons.

This is very related to @mkoniecz last comment

moving these two icons to .amenity-low-priority to avoid blocking more important icons and labels

EDIT: +1 to avoid blocking more important icons and labels

[daganzdaanda]

moving these two icons to .amenity-low-priority
definitely!

[matthijsmelissen]

Rebased.

[matkoniecz]

@math1985 Can you move these two icons to .amenity-low-priority to avoid blocking more important icons and labels?

[matthijsmelissen]

Sorry I forgot, done now.

[matkoniecz]

It is hard to find place with fully mapped benches and waste baskets, but in such places rendering of these objects is too prominent. I would propose pushing benches to z19 and waste baskets to z20 (or at least - waste baskets to z20).

http://www.openstreetmap.org/#map=19/50.07081/19.91222

Also, is it possible to ensure than benches have priority over waste baskets?

http://www.openstreetmap.org/#map=19/50.06866/19.98983

[pnorman]

tile.osm.org doesn't render z20. I'd be against any changes for zoom level 20, except if continuing a size progression. These changes would only be visible to those running their own deployment of osm-carto.

We've used z17 for the cutoff at which everything renders for other features, and I'd prefer to do so for benches and bins. If we feel benches/bins are too strong, perhaps reducing the size? Saying z19 only feels like a cartographic cop-out.

[matkoniecz]

tile.osm.org doesn't render z20

Right, I forgot. Than I repeat my

Maybe bin icon can be even smaller?

[nebulon42]

I made a smaller version of waste basket: https://github.com/nebulon42/osmic/blob/master/outdoor/waste-basket-10.svg

[matthijsmelissen]

Rebased, and made the following changes:

• Render waste_basket smaller
• Render bench only from z19
• Give bench priority over waste_basket

This is again ready for review.

[matkoniecz]

I would support merging. @math1985 - would it be OK for me to squash 3 commits from this PR into one before merging? It is case of "improve previous commit" rather than separation of independent changes.

[matthijsmelissen]

Yes, please squash. In general I think it's clearer if the reviewer squashes rather than the author of the PR, as it makes it easier for the reviewer to see what has changed.

[matkoniecz]

Merge done via cli in 376a1b4