New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up roads.mss, refactor road colour script #2220
Split up roads.mss, refactor road colour script #2220
Conversation
565f9df
to
dadb8cd
Compare
847315e
to
1bd1ff0
Compare
👍 in principle, but I haven't done a code review yet |
I opened jdhoek#1 with some changes and support for road shields Can tertiary not be special-cased in |
@pnorman Great, I'll have a look. |
We could check the status of road-colors.yaml (that it generates the same file as the checked in version) with Travis. But this could be done later. |
With the help of @pnorman |
The generated colour values now reside in road-colors-generated.mss, and have been removed from roads.mms. road-colors-generated.mms is generated by the colour script, and should not be edited manually. To regenerate it, edit road-colors.yaml and run: ``` ./scripts/generate_road_colours.py > road-colors-generated.mss ``` The original output of the colour script provided some info about the amount of loss caused by converting from CIE lch to RGB. To get this output, call the script with the `-v` flag (for verbose).
Refactor generate_shields.py to use road-colors.yaml as well. It now uses methods from generate_road_colours.py to do this.
eb2063a
to
d13cb88
Compare
Thanks. I thought about doing this but didn't want to get into that script as well. |
Turned out to be a minor change in that script, so it seemed beneficial. I did alter the spacing to align with Python standards and |
Great work! |
The generated colour values now reside in road-colors-generated.mss, and
have been removed from roads.mms. road-colors-generated.mms is generated
by the colour script, and should not be edited manually. To regenerate
it, edit road-colors.yaml and run:
The original output of the colour script provided some info about the
amount of loss caused by converting from CIE lch to RGB. To get this
output, call the script with the
-v
flag (for verbose).