Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different color for tertiary? #1974

Closed
RicoElectrico opened this issue Nov 14, 2015 · 29 comments
Closed

Use different color for tertiary? #1974

RicoElectrico opened this issue Nov 14, 2015 · 29 comments

Comments

@RicoElectrico
Copy link

I think new white color of tertiary roads is misleading, kind of breaking the mapper feedback for novices. It should be clear that tertiary is meant for roads that are somehow more important than residential, and the thickness gradation isn't really that easy to see.
Another issue is that in some areas like here, tertiary is overused as a default. When it was yellow, it was very easy to see and it would catch attention. I've also seen tertiary abuse in Africa or Middle East cities, but I don't remember where exactly.

@polarbearing
Copy link
Contributor

Could you specify what you mean with "overuse"? In your example, there are some main roads going through the villages, so tertiary appears fine to me (subject to the country-specific tertiary definition and ground survey of priorities).

There are certainly pros and cons of white wider tertiary, but they have been discussed here at length, and a decision made in favour. For me, the width works fine.

@RicoElectrico
Copy link
Author

My reasoning is that in this example tertiary is effectively the lowest tier besides driveways. If these were larger villages (that is with residential streets branching off), putting tertiary everywhere would be fine.
And do you see something? Judging relative width is not feasible when there are no thinner roads around. That's my point.
A slight yellow tint would be OK. Or some other minor variation, it doesn't have to be prominent.

It's always like that, no matter how big discussion is, if it can't be deployed as a public beta, there always will be something that people find not right. So because I guess public preview is not technically feasible due to resources needed, no discussion should be deemed final.

@matthijsmelissen
Copy link
Collaborator

There has been a public beta. It was announced here.

@Teiron
Copy link

Teiron commented Nov 14, 2015

I would like to express my support to this idea. Tertiary roads don't stand out enough.

But more importantly I keep hearnig about people feeling that road color change wasn't announced properly, despite great lot of talk at mailing lists, forums and here. I think there should be a easliy visible button on mainpage, which should link to "beta" version of map. This map may not be hosted permamently but maybe only one or two weeks before realese of new version of style. Users should be able to easliy give feedback somewhere where the developers will read it. Also button should be greyed out when beta is inactive.

This should quell some critcism, while enhancing cooperation within comunity.

@kocio-pl
Copy link
Collaborator

I think tertiary are just acceptable now, but I don't know how exactly they should be made better (the discussion about it brought us no working solution). So please try to focus on propositions to test rather than complain about the situation. The problem is already known, but we have no idea how to solve it and only constructive criticism can help us. I'm happy to make test renderings if someone has the idea.

Announcing big changes may be a good idea, however they are rare (like road redesign or making the buildings pale) and most of the changes are rather gradual.

@zibik
Copy link

zibik commented Nov 16, 2015

My proposal for tertiary colour (#feffdf):
(see: Trakt Królewski, Kosmowska)
tertiary-feffdf-kadr
(see: Bracka, Krucza etc.)
tertuary-feffe3

@matthijsmelissen
Copy link
Collaborator

Looks fine to me, and in any case better than the

Personally I'm am still not sure what to think about the white tertiary roads. On the one hand, it makes the map look calmer because there is one colour less, and in most situations, width is still enough to recognize the tertiaries. In the other hand, there are also situations where it is possible to confuse two nearby residential roads with one tertiary, such as here the Arthur van Schendelstraat on z14 and z15.

@polarbearing
Copy link
Contributor

The proposal is not bad in the road hierarchy, however it is quite close to the educational yellow. The latter could be solved if we migrate towards boundaries for the amenities as in #1624.

@kocio-pl
Copy link
Collaborator

I'm not quite sure about the proposition visibility, however the similarity to "educational yellow" would not be that significant, because tertiary road and educational/hospital area probably never overlap and their shapes are enough to recognize them easily. But what about planned farmland color change?

z12:
oz9 ll m

z13:
z9e304ye

I suggest opening the images in separate tabs, since it is probably scaled to fit the column. My code branch for it is located here.

@malenki
Copy link

malenki commented Nov 18, 2015

I also would like to see the tertiary highways more distinguished from the unclassifieds.

@kocio-pl
Copy link
Collaborator

Do you have some colors for them as a proposition?

@malenki
Copy link

malenki commented Nov 18, 2015 via email

@mboeringa
Copy link

But what about planned farmland color change?

It seems doable. The distinction is not pronounced, as all colors are pale, but you can still make them out quite easily.

@donaldrnoble
Copy link

One solution might be to introduce a deeper purple colour for motorways, and then shift the "new" colours down one class of road. This would, IMO, overcome a few issues (from a UK perspective possibly).

  • Motorways would be closer to blue, and might stand out a bit more (both complaints I have seen elsewhere), without being too close to water coloured.
  • Primary, Secondary, & Tertiary roads would be reddish-orange, orange, and yellow respectively - which is close to Ordnance Survey maps. However the "new" OSM colours have the advantage of being a more continuous intensity spectrum against importance, which I really like.
  • It also stays away from the issues highlighted above, of being too close to farmland or education colours.

I appreciate that purple might cause conflicts with borders, but these are generally rendered in light pastel shades, so a darker purple motorway with casings could look quite different.

I don't have a specific she of purple in mind at this time,just suggesting this as a possibility for discussion

@kocio-pl
Copy link
Collaborator

kocio-pl commented Mar 5, 2016

Are we still gonna keep this proposal or consider @donaldrnoble proposition? Original @zibik proposal would be trivial to deploy, dropping would be even easier (just closing this issue), but @donaldrnoble issue needs someone willing to get into details (hex color values) and test it.

@mboeringa
Copy link

Are we still gonna keep this proposal or consider @donaldrnoble proposition? Original @zibik proposal would be trivial to deploy, dropping would be even easier (just closing this issue), but @donaldrnoble issue needs someone willing to get into details (hex color values) and test it.

I think the recolouring of only tertiary per the proposal here is the best option. It is a minor change that may help some and doesn't really hurt anything.

We've had plenty of discussion about alternative coloring schemes but no real final consensus in the #1736 thread. Now @matkoniecz's new color scheme is finally there, I think it has grown upon many, also considering no real complaints here..., why would we again make a big switch now?

@aceman444
Copy link

Yes, please make tertiary a bit different from the white of other roads.

@gravitystorm
Copy link
Owner

Although this was marked as closed after #2078 was merged, there was a problem with this PR that meant it was reverted in 4fd9a5d

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 11, 2016

Now we have two different propositions. As I said here: if we decide to make tertiary roads yellow, do we want to manually add color for them (my solution) or use the script and change also all the existing road colors (@jdhoek's solution)? I like the first option more, but I don't reject the second one.

Manual option is less intrusive (+) and a drawback is that tertiary color is close to secondary color (-), while scripted option makes the colors differences more uniform and the difference between tertiary and secondary is bigger (+), but we make global color changes (-), so we should test if we like new colors for the roads.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 11, 2016

In terms of maintaining the balance of the road classes palette, using the script seems preferable. With #2220 in place it should be possible to tweak the various options more easily without having to know Python.

I expect the PR to be finished some time this week — I am going to add a few fixes contributed by @pnorman .

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 11, 2016

I like your refactoring very much, especially splitting script from the color configuration and documenting things!

If we want more balanced road colors, it means testing worldwide and discussing it, because the scope will be much broader than just tertiary.

See also this comment from @mboeringa.

@pnorman
Copy link
Collaborator

pnorman commented Jul 13, 2016

With the refactoring merged we're unblocked and can now make changes by modifying the script.

@kocio-pl
Copy link
Collaborator

I made a new version of #2085 after refactoring, but with more colors and sizes for tertiary roads - see #2228. This is current "tertiary-colors-only" variant, of course making a new PR version of #2219 ("uniform-road-colors") is another possible way.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 13, 2016

If anyone wants to experiment with the road colours via road-colors.yaml, change the values in that file and run:

./scripts/generate_road_colours.py > road-colors-generated.mss
./scripts/generate_shields.py

To include tertiary roads, add - tertiary to the list of roads.

Not all values are possible; generate_road_colours.py will throw an error if you pick values that cannot be converted to RGB.

@nebulon42
Copy link
Contributor

Not all values are possible; generate_road_colours.py will throw an error if you pick values that cannot be converted to RGB.

That's why I recommend to switch to HUSL. Carto supports this since 0.16.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 13, 2016

HUSL is certainly interesting, nice project. However, the trade off for the full range of the input coordinates at any combination is a distortion in the chroma values for a generated sequence of colours; the purpose of the script is to generate a naturally progressing sequence of colours. Colours are limited to what RGB supports regardless of colour definition used.

@nebulon42
Copy link
Contributor

nebulon42 commented Jul 13, 2016

From a designer's perspective this trade-off is worth taking if I can avoid the trial-and-error process of finding a color that has a representation in RGB. At any rate it is better than using HSL, which is often the most popular choice. You also should not forget that as soon as you use functions like lighten and darken in Carto you are doing the operations in the HSL color space unless you use perceptual colors or use lightenp or darkenp, then Carto will do the calculations in HUSL.

@pnorman
Copy link
Collaborator

pnorman commented Jul 13, 2016

For the colour script where it's generating a sequence, I recommend Lch over HSUL. We're not inputting in RGB or HSL and we're not using functions like lighten or darken.

@matthijsmelissen
Copy link
Collaborator

Closing this per #2228 (comment).

Thanks everybody for the work put in investigating this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.