Replace VMAP0-data by OSM-data #2969
Conversation
Currently, we use VMAP0-data instead of OSM-data to indicate built-up areas on zoom levels 8 and 9. This PR replaces the VMAP0-data with the OSM landcover data. Resolves gravitystorm#256.
|
Is there documentation to be updated? |
There was a problem hiding this comment.
Aside from the stray newline, a few other changes need to be made
- Travis needs to not create the empty builtup shapefile
- The documentation needs adjusting
- The
builtuplayer needs removing, as right now a new install will look for an empty shapefile if that layer is used. https://github.com/gravitystorm/openstreetmap-carto/pull/2969/files#diff-2d6c6d06f63a6fab47286addedefc335R73 is the layer in question.
I haven't looked at how effective this approach is and the cartographic results.
project.mml
Outdated
| ('natural_' || (CASE WHEN "natural" IN ('wood', 'sand', 'scree', 'shingle', 'bare_rock') THEN "natural" ELSE NULL END)) AS "natural", | ||
| ('wetland_' || (CASE WHEN "natural" IN ('wetland', 'mud') THEN (CASE WHEN "natural" IN ('mud') THEN "natural" ELSE tags->'wetland' END) ELSE NULL END)) AS wetland, | ||
|
|
There was a problem hiding this comment.
You forgot to remove this empty line.
|
I like the idea. |
* Fix travis * Fix documentation * Remove layer from project.mml * Remove empty newline
|
I have applied the requested changes. |
|
Rendering test of south of the Uzbekistan (as originally reported in #256): z8 z9 |
|
Seems I forgot to push. Should be better now! |
This change is important in the areas with lacking landuse/natural tagging. In other places the change won't be too big (z8-9 means very big cities and we have them visible now). The Uzbekistan sample shows that both data sets are different, but comparable. |
|
The Uzbekistan area seems fine to me. Likely there are some places on earth where this will be a degradation (if landuse has not been drawn) but I'd consider it an improvement not to show settlements if we don't have them in OSM. |
|
All requested changes have been added. @pnorman didn't check the cartographic results, if you're fine with that this can be merged. |
|
@pnorman rarely comments here for some time, which makes it harder to discuss changes. But I also believe this is not about cartographic results (they are similar), but rather about data consistency and dropping external dependencies (both of which are obvious), so I think we should really merge it. |
Currently, we use VMAP0-data instead of OSM-data to indicate built-up areas
on zoom levels 8 and 9. This PR replaces the VMAP0-data with the OSM
landcover data.
Resolves #256.