Adding rendering for amenity=police and amenity=fire_station areas

[kocio-pl]

Related to #3045.
Resolves #848.

Rendering police and fire station areas with the same hatching as new military area style, as discussed before. It will make uniformed services areas to use similar look.

Examples:
Police

Fire services

Comparison with military area rendering

[matthijsmelissen]

I'm not sure about the diagonal dashing, it suggests access is forbidden, while that is not true for many police/fire station grounds.

[kocio-pl]

Do you think that just changing to similar overlay file without hatching would be OK, or prefer standard light pink background with the same outline?

[polarbearing]

I thought we intended to reduce the hatching?
My preference would be the same outline as the new military (need to add that to #3045 for comparison), but no overlay and no hatching.
Thus we follow the concept of #3045 with outlines for campuses, and use the same colour for uniformed services.

[kocio-pl]

Updated code:

[polarbearing]

How does the low-zoom version look like where you have line-width=1.0 ?
Could we compare it with a no-fill version?

[kocio-pl]

What do you mean with "low-zoom version"?

I can test it, but I wouldn't like to diverge too far from new military rendering (that's why I started with hatching).

[polarbearing]

I mean [zoom >= 13] line-width: 1.0 in the code. I guess your examples are [zoom >= 15] line-width: 2.

As for the fill, you are currently proposing a new colour for the uniformed-amenities. In 3045-comment @Tomasz-W argues that these campuses are more and more filled with landcovers, so we might focus on outlines-only anyway. For the touristic accommodation, for example, I would not want light-blue fill in addition to the outline.

[Tomasz-W]

Resolves #848

[kocio-pl]

I don't know if I will find that big police/fire area - the border is however the same as for the current military areas on the same zoom.

The color definition is new, but it's just how the lighter parts of military areas look like on the ground color, because I think it's the most generic color for military areas. I will try to make the rendering with only the outline to compare pretty soon.

[polarbearing]

This is a fairly large one:
https://www.openstreetmap.org/way/5095457

[matthijsmelissen]

Looks good to me!

[kocio-pl]

@polarbearing Sorry that I haven't found the time to check your proposition, but this way we would loose uniformity of such areas - lack of hatching is enough for me.

[polarbearing]

If the outline behaviour is copied from the military, I'd be happy enough. Not time to test, either. Will have a look when deployed.

[Tomasz-W]

@kocio-pl
An red outline is missing here:
https://www.openstreetmap.org/way/513298808
and here:
https://www.openstreetmap.org/way/460521303
Is it some bug or what?

[kocio-pl]

It's visible in both cases, but only near gates. Probably grass and buildings are eclipsing the outline.

[Tomasz-W]

Don't you think that it should work like this: barriers > outlines > landcover? There will be more and more cases like in examples above, because the map gets more and more detailed, When outlines are covered by landcover, we lose information about area range/ boundaries, and they become useless.

[kocio-pl]

Yes, I think it should. Anybody willing to play with the code and check whether it wouldn't break anything else?

[polarbearing]

Sounds plausible. Should be done for the tourism outline as well.
Earlier this year we had lowered the tourism outline (next to the military) to show the barriers (fences). Would be good to have that sorted before we add further tourism (museum, accommodation) outlines, see #3045
Please note we had a similar discussion there, regarding highways. I still think highways should remain above the outline.