-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public transport shelter should not be labeled with elevation #4313
Conversation
Thank you for opening this PR, @GoutamVerma Could you create “before” and “after” images of an object which will have a different rendering after this change? I would always recommend doing this, to make sure that your changes have the expected effect and that there are no unintentional side effects from the change. |
@GoutamVerma Could you create “before” and “after” images of an example where this change will affect the rendering? |
This requires testing - otherwise it is non-controversial i think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Paul Dicker <pitdicker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes merged this should now be working, but I wonder about doing this for a total of 109 nodes.
This could use a review from someone else. I'm not opposed to the change, although don't think it's worth it for the small number of nodes. |
According to https://taginfo.openstreetmap.org/tags/amenity=shelter#combinations only 0.83% of 37% percent of features lack a Of the values with more than 1000 uses, only
Perhaps the better solution is to remove the tag | number | percentage | wiki | description In contrast, there are over 4000 In conclusion, could make sense to either expand this PR to exclude more values of A simpler solution would be to remove |
Looking a bit more, I now realize that most Also |
I’m not certain the best course of action. @imagico do you still support merging this PR? It looked like you were in favor above. |
I concur with your analysis that
I would still be moderately in support of this idea because (a) the alternative to complete remove ele rendering from amenity=shelter without shelter_type would mean a significant loss of useful information in many mountain regions. The idea of extending the list of shelter_type values to be not rendered with ele is worth discussing but i am not sure if there are values where this is similarly clear as with shelter_type=public_transport. There are plenty of gazebos at viewpoints in mountain areas for example where ele values are highly useful. I would however prefer it if the introduction of a special case for ele on shelter_type=public_transport would be combined with a symbol variant (i.e. adjusting #4317 to use a symbol that is a minor variation of the generic shelter symbol). That would help mappers to intuitively understand the differences in labeling logic. And it would help support mappers in more precise classification of shelters which could help us - and other styles - to improve our rendering logic in the future. |
Fixes #4270
Changes proposed in this pull request:
-
OR (amenity = 'shelter' AND tags->shelter_type NOT IN (public_transport, picnic_shelter))