Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework diary entry comments #26

Open
gravitystorm opened this issue Nov 7, 2018 · 0 comments
Open

Rework diary entry comments #26

gravitystorm opened this issue Nov 7, 2018 · 0 comments

Comments

@gravitystorm
Copy link
Owner

Diary entry comments are separate from diary entries, and it makes sense to split them into different controllers to work on the given model.

However, there's one little gotcha that I found out. Comments are always created from the diary entry page, and when the comment is invalid (e.g. blank) the same diary entry is rendered, in order to show the error messages. This is quite hard to do from diary_comment#create or similar, so it needs some thought as to what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant