Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds stepper library with an example #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

agwatic
Copy link

@agwatic agwatic commented Mar 2, 2014

No description provided.

@alexanderhiam
Copy link
Member

Awesome, thanks!

One issue though, on line 28 of Stepper.py:

    def __init__(self,steps = 100 , pin_1, pin_2, pin_3=None, pin_4=None):

if you want steps to have a default value it'll have to come after the pins without defaults. Or would you rather have steps first without a default value? No need to submit another pull request, just let me know what you meant and I'll make the change when I merge it.

@agwatic
Copy link
Author

agwatic commented Mar 4, 2014

ok , let it

def  __init__(self, pin_1, pin_2, pin_3=None, pin_4=None, steps = 100 ):

I just made it as the stepper library in Arduino

@alexanderhiam
Copy link
Member

There seems to be a few other bugs, have you tested this yet? It'll need to be tested before I can pull it into the main branch, and I'm not sure I have an H-bridge on hand.

@agwatic
Copy link
Author

agwatic commented Mar 10, 2014

This is the only bug I can see because I haven't a beagleboard yet so unfortunately I didn't test my code. can you tell me the bugs you found ?

@alexanderhiam
Copy link
Member

It's just a few minor Python bugs, a couple missing self.s, etc.

I can clean that that stuff up, but I'll have to test it with a motor to make sure it works before pushing it to the main branch. I'll see if I can find an H-bridge in my junk bin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants