feat: make phpcs severity level configurable #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add inputs to allow configuring error and warning severity levels. This allows suppressing messages in the Mage-OS repository that are ignored in upstream Magento Open Source CI, too. No breaking changes.
5 tasks
damienwebdev
requested changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inputs to allow configuring error and warning severity levels.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The phpcs command is always executed with the built in default severity level 5.
Fixes: N/A
What is the new behavior?
Three new optional inputs allow specifying the error and warning severity level.
This allows suppressing messages in the Mage-OS repository that are ignored in upstream Magento Open Source CI, too.
If no values are specified the built in default value is used.
Does this PR introduce a breaking change?
Other information
Reference Mage-OS PR mage-os/mageos-magento2#22