Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 seems to still not work #67

Closed
smazurov opened this issue Aug 5, 2012 · 4 comments
Closed

1.5 seems to still not work #67

smazurov opened this issue Aug 5, 2012 · 4 comments

Comments

@smazurov
Copy link

smazurov commented Aug 5, 2012

Hey I installed sc2reader and was playing around with it, i couldn't get it to work with the 1.5 replay i tried

$ sc2printer test-replays/1v1-1.5.0-us.SC2Replay

--------------------------------------
test-replays/1v1-1.5.0-us.SC2Replay

Traceback (most recent call last):
  File "/usr/local/bin/sc2printer", line 8, in <module>
    load_entry_point('sc2reader==0.3.3', 'console_scripts', 'sc2printer')()
  File "build/bdist.macosx-10.7-intel/egg/sc2reader/scripts/sc2printer.py", line 93, in main
  File "build/bdist.macosx-10.7-intel/egg/sc2reader/scripts/sc2printer.py", line 15, in doFile
  File "build/bdist.macosx-10.7-intel/egg/sc2reader/factories.py", line 269, in load_replay
  File "build/bdist.macosx-10.7-intel/egg/sc2reader/resources.py", line 177, in read_data
  File "build/bdist.macosx-10.7-intel/egg/sc2reader/readers.py", line 265, in __call__
sc2reader.exceptions.ReadError: Unknown event code, Type: 0, Code: 28

replay in question can be found at http://drop.sc/234236

@GraylinKim
Copy link
Owner

Yeah, that is true. I'll have the fix in the next couple days. I have a working parser running locally but there are still a couple integration issues I need to address. In the meantime you can run with load_level=2 and disable game event parsing.

import sc2reader
replay = sc2reader.load_replay(filename, load_level=2)

This will still have basic replay, player, team, and winner information.

@GraylinKim
Copy link
Owner

The v15 branch now parses v1.0-1.5 replays with no known problems. I'll be cleaning this up and merging to master soon but you can check it out if you are in a hurry.

@smazurov
Copy link
Author

Thank you! I'll try to take a look at it as soon as I get some free time.

@GraylinKim
Copy link
Owner

v15 support is now in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants