Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors when adding remotes via editor #2594

Closed
arantius opened this issue Sep 28, 2017 · 1 comment
Closed

Handle errors when adding remotes via editor #2594

arantius opened this issue Sep 28, 2017 · 1 comment
Milestone
4.5

Comments

@arantius
Copy link
Collaborator

  1. Edit any script.
  2. Add (e.g.) a @require, but point to a bad URL.
  3. It's just downloaded and used as is, no checking or prompting.

In the case of a 404 require, you'll probably get an error about an unexpected < -- opening of an HTML tag interpreted as a less than which doesn't belong.
@arantius arantius added this to the 4.x milestone Sep 28, 2017
@arantius arantius removed this from the 4.x milestone Jan 19, 2018
@arantius arantius added this to the 4.5 milestone Feb 22, 2018
@arantius arantius mentioned this issue Feb 22, 2018
Closed
@arantius
Copy link
Collaborator Author

arantius commented Jun 7, 2018

#2858 / #2900 addressed this. But I realized there's one more important detail to cover so I'll close this with a commit addressing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5
Development

No branches or pull requests
1 participant
@arantius