Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<menuitem> will be disabled in Firefox v85 #3099

Closed
tgn-ff opened this issue Jan 10, 2021 · 7 comments · Fixed by #2770
Closed

<menuitem> will be disabled in Firefox v85 #3099

tgn-ff opened this issue Jan 10, 2021 · 7 comments · Fixed by #2770

Comments

@tgn-ff
Copy link

tgn-ff commented Jan 10, 2021

See Bug 1680596. I noticed it on Nightly due to the disabled scripts not being faded anymore.

@StigNygaard
Copy link

See #3078

esperecyan added a commit to esperecyan/greasemonkey that referenced this issue Jan 11, 2021
@arantius
Copy link
Collaborator

I see it still working in 85.0b9 .

@tgn-ff
Copy link
Author

tgn-ff commented Jan 15, 2021

dom.menuitem.enabled defaults to false in 85.0b9 on my end.

@arantius
Copy link
Collaborator

Did a fresh install of Nightly and
image
I see the menu command polyfill still work fine, in 86.0a1.

The "disabled scripts not greyed out" issue, I do see. I'm confused about whether that's relevant to this change or not. Rivets/tinybind is just not setting the "disabled" attribute, and this persists even if I change <menuitem>s to <div>s.

@StigNygaard
Copy link

StigNygaard commented Jan 18, 2021

@arantius I don't understand your screenshot. What are you trying to show? The "Take a Screenshot" item is not created from html5 <menuitem>, it's a standard feature of Firefox. Isn't it?
Also the html5 menuitems is/was placed in top of context-menu. You can use webextension API though to add items in bottom of contextmenu.

Or am I totally misunderstanding what you are trying to show?

@arantius
Copy link
Collaborator

I was confused. (The GM.rmc command I use most often is from the "Search with Google" script, because Google is not the default engine in my main profile. In this test profile I installed it and thought I saw it run and create a menu item. Nope, that's the standard (Google is the default by default!) search context item.)

Install https://gist.github.com/arantius/10f7a8c998c2d06d84b8f9dad48b3f92 in Firefox stable (84) and you see a context item:

image

Install it in Nightly (86), nothing. Report confirmed.

@arantius
Copy link
Collaborator

And now that I finally understand: This is a dupe of #3078, just a stronger reason to proceed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants