Skip to content

Commit

Permalink
Note to self
Browse files Browse the repository at this point in the history
  • Loading branch information
abegong committed Jul 18, 2019
1 parent 89a3173 commit 2bf6abd
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/test_jupyter_ux.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ def test_display_column_expectations_as_section(basic_expectation_suite):

def test_display_column_evrs_as_section():
#TODO: We should add a fixture that contains EVRs

df = ge.read_csv("./tests/test_sets/Titanic.csv")
df.profile(BasicDatasetProfiler)
evrs = df.validate(result_format="SUMMARY") # ["results"]
Expand All @@ -129,6 +128,10 @@ def test_display_column_evrs_as_section():
return_without_displaying=True
)
print(html_to_display)

#FIXME: This snapshot test is brittle, since it depends on the behavior of the profiler, renderer, and view.
# At the very least, we can take the profiler out of the loop by creating a new fixture for it.
# Next time this snapshot test fails, please do that.
assert html_to_display == """\
<div id="section-1" class="ge-section container-fluid">
<div class="row">
Expand Down

0 comments on commit 2bf6abd

Please sign in to comment.