Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should expectation decorators add expectations that cannot be executed to the expectation configuration? #3

Closed
jpcampb2 opened this issue Sep 11, 2017 · 3 comments
Closed

Should expectation decorators add expectations that cannot be executed to the expectation configuration? #3

jpcampb2 opened this issue Sep 11, 2017 · 3 comments

Comments

@jpcampb2
Copy link

For example, if an expectation is written on a column that does not exist, currently that expectation will immediately be added, even if it is never even evaluated.
@jpcampb2
Copy link
Author

POV: Not by default, but users should be able to change that behavior at the expectation or DataSet level.

@jpcampb2
Copy link
Author

I think this is related to #33 (and that if they should be able to choose to add such expectations that is actually another parameter for the enhanced decorators).

(I'd recommend folding this into #33 and closing it).

@jpcampb2
Copy link
Author

+1. Closing and redirecting to Issue #33 .

abegong added a commit that referenced this issue Dec 1, 2017
@abegong
Merge pull request #3 from great-expectations/develop
9392576 
bring our fork in line with trunk
jcampbell added a commit that referenced this issue Jun 7, 2019
@jcampbell
Merge pull request #3 from superconductive/dev_eug_0
2680245 
Changed DataContext to class to represent a project - a collection of dataset types
@jcampbell jcampbell mentioned this issue Aug 25, 2020
Merged
jdimatteo added a commit to jdimatteo/great_expectations that referenced this issue Jul 30, 2021
@jdimatteo
Merged in my work from great-expectations#3135:
3564696 
1. added documentation
2. using helper function _create_bigquery_engine with gcp project environment variable
3. added bigquery specific list in candidate_test_is_on_temporary_notimplemented_list_cfe
4. removed bigquery specific test files, so we can just use the already existing ones (along with bigquery specific notimplemented list per great-expectations#3)
@jdimatteo jdimatteo mentioned this issue Jul 30, 2021
Merged
6 tasks
Shinnnyshinshin pushed a commit that referenced this issue Jul 30, 2021
@jdimatteo
Merged in my work from https://github.com/great-expectations/great_ex… (
25a008f 
#3158)

* Merged in my work from #3135:

1. added documentation
2. using helper function _create_bigquery_engine with gcp project environment variable
3. added bigquery specific list in candidate_test_is_on_temporary_notimplemented_list_cfe
4. removed bigquery specific test files, so we can just use the already existing ones (along with bigquery specific notimplemented list per #3)

* enabled the expect_column_values_to_be_unique test, which passes now with Will's changes
@Shinnnyshinshin Shinnnyshinshin mentioned this issue Jun 23, 2023
Merged
@Long-Nguyen-Paidy Long-Nguyen-Paidy mentioned this issue Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpcampb2