Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged in my work from https://github.com/great-expectations/great_ex… #3158

Conversation

jdimatteo
Copy link
Contributor

@jdimatteo jdimatteo commented Jul 30, 2021

Merged in my work from #3135:

  1. added documentation
  2. using helper function _create_bigquery_engine with gcp project environment variable
  3. added bigquery specific list in candidate_test_is_on_temporary_notimplemented_list_cfe
  4. removed bigquery specific test files, so we can just use the already existing ones (along with bigquery specific notimplemented list per above number 3)

Example running:

(venv) jdimatteo@dimo:~/dev/great_expectations_fork_2$ time GE_TEST_BIGQUERY_PROJECT=jdimatteo-v pytest tests/test_definitions/test_expectations_cfe.py --bigquery --no-spark --no-postgresql -k bigquery
...
================================================================================= 173 passed, 266 skipped, 932 deselected, 159 warnings in 875.95s (0:14:35) =================================================================================

real	14m39.486s
user	0m30.010s
sys	0m3.358s

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

1. added documentation
2. using helper function _create_bigquery_engine with gcp project environment variable
3. added bigquery specific list in candidate_test_is_on_temporary_notimplemented_list_cfe
4. removed bigquery specific test files, so we can just use the already existing ones (along with bigquery specific notimplemented list per great-expectations#3)
@@ -1,50 +0,0 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shinnnyshinshin I think it would be good to use the existing test definitions, e.g. tests/test_definitions/column_map_expectations/expect_column_values_to_be_unique.json. This PR changes it so these existing files are used instead.

"bigquery tests are requested, but unable to connect "
)
"bigquery tests are requested, but unable to connect"
) from e
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the cause with from is very helpful for debugging and it would be helpful if GE did that whenever catching and re-raising an exception!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) thank you very much. I'll start making some noise about this

@Shinnnyshinshin Shinnnyshinshin self-requested a review July 30, 2021 23:27
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely wonderful work. Very excited to see where this goes

@Shinnnyshinshin
Copy link
Contributor

Seeing some linting errors, but I can take care of them on my end.

@Shinnnyshinshin Shinnnyshinshin merged commit 25a008f into great-expectations:working-branch/enable-bigquery-flag Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants