New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged in my work from https://github.com/great-expectations/great_ex… #3158
Conversation
1. added documentation 2. using helper function _create_bigquery_engine with gcp project environment variable 3. added bigquery specific list in candidate_test_is_on_temporary_notimplemented_list_cfe 4. removed bigquery specific test files, so we can just use the already existing ones (along with bigquery specific notimplemented list per great-expectations#3)
@@ -1,50 +0,0 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinnnyshinshin I think it would be good to use the existing test definitions, e.g. tests/test_definitions/column_map_expectations/expect_column_values_to_be_unique.json. This PR changes it so these existing files are used instead.
"bigquery tests are requested, but unable to connect " | ||
) | ||
"bigquery tests are requested, but unable to connect" | ||
) from e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the cause with from
is very helpful for debugging and it would be helpful if GE did that whenever catching and re-raising an exception!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) thank you very much. I'll start making some noise about this
…with Will's changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely wonderful work. Very excited to see where this goes
Seeing some linting errors, but I can take care of them on my end. |
25a008f
into
great-expectations:working-branch/enable-bigquery-flag
Merged in my work from #3135:
Example running:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!