[FEATURE] Enable passing boto3 options to TupleS3StoreBackend #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1691 +/- ##
===========================================
- Coverage 77.85% 77.84% -0.02%
===========================================
Files 135 135
Lines 15680 15692 +12
===========================================
+ Hits 12208 12215 +7
- Misses 3472 3477 +5
Continue to review full report at Codecov.
|
mgorsk1
force-pushed
the
feature/boto3_options_for_s3_store_backend
branch
from
9a16e68
to
ed628fe
Compare
mgorsk1
force-pushed
the
feature/boto3_options_for_s3_store_backend
branch
from
ed628fe
to
79bd6f7
Compare
|
@alexsherstinsky Is this related to the boto change you just merged in #2364 ? How should we proceed with this PR here? |
robertparker
pushed a commit
to robertparker/great_expectations
that referenced
this pull request
Feb 4, 2021
…toreBackend (Thanks for great-expectations#1691 to @mgorsk1!) (great-expectations#2371) * LINT * Adding possibility to pass boto3_options to TupleS3StoreBackend -- thanks to PR 1691 by mgorsk1 (Community Contributor). * PR note in changelog.
alexsherstinsky
added a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…toreBackend (Thanks for great-expectations#1691 to @mgorsk1!) (great-expectations#2371) * LINT * Adding possibility to pass boto3_options to TupleS3StoreBackend -- thanks to PR 1691 by mgorsk1 (Community Contributor). * PR note in changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Thank you for submitting!