[BUGFIX] Add python=3.7 argument to conda env creation #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyburdi
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
Thank you for this contribution @scouvreur ! Without specifying python you may get the system python version, which defaults to Python 2 on OSX for example. Good catch.
FYI - I just added a note to clarify that you can select other python versions and added a changelog entry. I'll merge as soon as tests pass.
alexsherstinsky
pushed a commit
to alexsherstinsky/great_expectations
that referenced
this pull request
Feb 19, 2021
…tions#2391) * Add python=3.7 argument to conda env creation * Add changelog entry and clarify other python versions are acceptable * fix changelog Co-authored-by: Anthony Burdi <anthony@superconductive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #2390
Changes proposed in this pull request: