[ENHANCEMENT] CLI global options and checkpoint functionality for v3 api #2497
Conversation
#2418) * Modifying getting started content to use CSV and update to work with new Checkpoints
…checkpoints-02_15_2021_1 CLI Checkpoints List functionality.
…checkpoints-02_15_2021_1 CLI Checkpoints List functionality.
Co-authored-by: Taylor Miller <Aylr@users.noreply.github.com>
The name of the data source can't be present for the method to work Co-authored-by: Eugene Mandel <eugene.mandel@gmail.com>
…usage_statistics_events-03_02_2021_10 Change cli_version to api_version throughout the CLI subsystem.
…s in the notebook
…nt-new-notebook-updates `checkpoint new` notebook updates
…nt (#362) * * removed coloring from v2/v3 API message * remove experimental flags, unused imports * more consistent capitalization in checkpoints CLI
CLI global options and checkpoint functionality for v3 api
anthonyburdi
requested review from
jcampbell,
alexsherstinsky,
Aylr,
spbail and
roblim
|
@anthonyburdi Please DO NOT MERGE until PR |
There was a problem hiding this comment.
This is AWESOME! Didn't do a code review deep dive - mostly exercised the new Checkpoint functionality for --v3-api and that worked great using the tmp_cli_uat repo. Just had a few minor comments, which might be just from my newb understanding of the new CLI architecture changes.
Regarding "Deprecated suite demo datasource profile", just confirming that this is just for --v3-api - got confused for a minute since CLI defaults to --v2-api for now.
| datasources paired with one or more Expectation Suites each. | ||
| """ | ||
| pass | ||
| directory: str = toolkit.parse_cli_config_file_location( | ||
| config_file_location=ctx.obj.config_file_location |
| "project", | ||
| "store", | ||
| "suite", | ||
| "validation_operator", |
There was a problem hiding this comment.
Shouldn't validation_operator be nixed here? Otherwise, we should add it to the general CLI help since it doesn't appear there (and it still works - list, run)
There was a problem hiding this comment.
@Aylr will have more detail here and please correct me if I'm wrong, but basically we still need validation_operator here to make sure that the old API can still access it, and we also need a stub validation_operator.py file with just validation_operator = None in it so it is found when click is looking for available commands. As for versioning the help text - I know @Aylr was working on that as well, I think we just haven't found a great solution there yet.
Thank you for your comment and for reviewing!! Correct! |
* Checkpoints fixes. * Typo. * Fix name of a test method to match its purpose. * Fixing Checkpoint runtime parameter processing and updating corresponding tests. * Fixing Checkpoint runtime parameter processing and updating corresponding tests.
…api (great-expectations#2497) - Added `--v2-api/--v3-api flag` - Added `--config` as global option - Deprecated `suite demo` `datasource profile` - All Checkpoint verbs for both api versions - Usage stats schema and events updated - Tests for all of the above
…api (great-expectations#2497) - Added `--v2-api/--v3-api flag` - Added `--config` as global option - Deprecated `suite demo` `datasource profile` - All Checkpoint verbs for both api versions - Usage stats schema and events updated - Tests for all of the above
Here are the items contained in this PR:
--v2-api/--v3-api flag--configsuite demodatasource profile