Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 #2547

Merged
merged 3 commits into from
Mar 16, 2021
Merged

[BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 #2547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb753e
pin sqlalchemy
Mar 15, 2021
78066d4
trigger pipelines
Mar 15, 2021
c6a5889
a simpler change
Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions great_expectations/datasource/datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class LegacyDatasource:
Each Datasource provides Batches connected to a specific compute environment, such as a
SQL database, a Spark cluster, or a local in-memory Pandas DataFrame.

Datasources use Batch Kwargs to specify instructions for how to access data from
relevant sources such as an existing object from a DAG runner, a SQL database, S3 bucket, or local filesystem.
Datasources use Batch Kwargs to specify instructions for how to access data from relevant sources such as an
existing object from a DAG runner, a SQL database, S3 bucket, or local filesystem.
Comment on lines -28 to +29
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just to trigger the full build


To bridge the gap between those worlds, Datasources interact closely with *generators* which
are aware of a source of data and can produce produce identifying information, called
Expand Down Expand Up @@ -379,7 +379,7 @@ def get_available_data_asset_names(self, batch_kwargs_generator_names=None):
] = generator.get_available_data_asset_names()
return available_data_asset_names

# TODO: move to connector
# TODO: move to dataconnector
def build_batch_kwargs(
self, batch_kwargs_generator, data_asset_name=None, partition_id=None, **kwargs
):
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev-sqlalchemy.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ pyodbc>=4.0.30 # sqlalchemy_tests
snowflake-connector-python==2.3.8 # sqlalchemy_tests
# END NOTE
snowflake-sqlalchemy>=1.2.3 # sqlalchemy_tests
sqlalchemy>=1.3.16 # sqlalchemy_tests
sqlalchemy>=1.3.16,<1.4 # sqlalchemy_tests
sqlalchemy-redshift>=0.7.7 # sqlalchemy_tests