Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 #2547

Merged
merged 3 commits into from Mar 16, 2021
Merged

[BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 #2547

merged 3 commits into from Mar 16, 2021

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Mar 15, 2021 •
edited

Changes proposed in this pull request:

  • SqlAlchemy had a 1.4.0 release on 3/15/21 and the package is not being properly imported in Azure containers, which results in the error below. (registry is sqlalchemy.dialects.registry which is None because sqlalchemy is None)
2021-03-15T22:21:38.9472435Z great_expectations/dataset/sqlalchemy_dataset.py:75: in <module>
2021-03-15T22:21:38.9474288Z     registry.register("snowflake", "snowflake.sqlalchemy", "dialect")
2021-03-15T22:21:38.9475680Z E   AttributeError: 'NoneType' object has no attribute 'register'
2021-03-15T22:21:39.3341309Z ##[error]Bash exited with code '4'.
  • This PR is to temporarily pin Sqlalchemy to < 1.4.0 in our requirements-dev-sqlalchemy.txt file. This will allow PRs that are currently blocked to move forward, as the "real" cause is either fixed or further investigated.
  • I would like to propose that this pinning be a temporary fix, and have the pin be removed as soon as possible.

@Shinnnyshinshin Shinnnyshinshin self-assigned this Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin changed the title [WIL] pin sqlalchemy [WIP] pin sqlalchemy Mar 15, 2021
Shinnnyshinshin
Shinnnyshinshin commented Mar 15, 2021
View reviewed changes
great_expectations/datasource/datasource.py
Comment on lines -28 to +29
Datasources use Batch Kwargs to specify instructions for how to access data from
relevant sources such as an existing object from a DAG runner, a SQL database, S3 bucket, or local filesystem.
Datasources use Batch Kwargs to specify instructions for how to access data from relevant sources such as an
existing object from a DAG runner, a SQL database, S3 bucket, or local filesystem.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just to trigger the full build

@Shinnnyshinshin Shinnnyshinshin marked this pull request as ready for review March 15, 2021 21:52
@Shinnnyshinshin Shinnnyshinshin changed the title [WIP] pin sqlalchemy Temporarily pin sqlalchemy to < 1.4.0 for sqlalchemy dev requirements Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin changed the title Temporarily pin sqlalchemy to < 1.4.0 for sqlalchemy dev requirements Temporarily Pin SqlAlchemy to < 1.4.0 Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin changed the title Temporarily Pin SqlAlchemy to < 1.4.0 Temporarily pin SqlAlchemy to < 1.4.0 Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin changed the title Temporarily pin SqlAlchemy to < 1.4.0 [WIP] Temporarily pin SqlAlchemy to < 1.4.0 Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin changed the title [WIP] Temporarily pin SqlAlchemy to < 1.4.0 [BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 Mar 15, 2021
@Shinnnyshinshin Shinnnyshinshin merged commit 5919a21 into develop Mar 16, 2021
@Shinnnyshinshin Shinnnyshinshin deleted the will/fix_snowflake_pipeline_issue branch March 16, 2021 00:12
@lukedyer-peak lukedyer-peak mentioned this pull request Mar 25, 2021
Closed
peterdhansen pushed a commit to peterdhansen/great_expectations that referenced this pull request Mar 29, 2021
[BUGFIX] Temporarily pin SqlAlchemy to < 1.4.0 (great-expectations#2547)
d61b804 
* pin sqlalchemy
@Shinnnyshinshin Shinnnyshinshin restored the will/fix_snowflake_pipeline_issue branch June 18, 2021 22:07
@Shinnnyshinshin Shinnnyshinshin deleted the will/fix_snowflake_pipeline_issue branch June 18, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aylr Aylr Aylr approved these changes

@roblim roblim Awaiting requested review from roblim

@jcampbell jcampbell Awaiting requested review from jcampbell

@anthonyburdi anthonyburdi Awaiting requested review from anthonyburdi

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky

@eugmandel eugmandel Awaiting requested review from eugmandel

@gilpasternak35 gilpasternak35 Awaiting requested review from gilpasternak35

@spbail spbail Awaiting requested review from spbail

@talagluck talagluck Awaiting requested review from talagluck

Assignees

@Shinnnyshinshin Shinnnyshinshin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shinnnyshinshin @Aylr