Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Update changelog (in both, ".md" and ".rtd" formats) #3189

Conversation

alexsherstinsky
Copy link
Contributor

@alexsherstinsky alexsherstinsky commented Aug 6, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • JIRA: GREAT-56/GREAT-90

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ Deploy Preview for knoxpod ready!

🔨 Explore the source changes: c691c45

🔍 Inspect the deploy log: https://app.netlify.com/sites/knoxpod/deploys/610d7a695a69ca00077727b1

😎 Browse the preview: https://deploy-preview-3189--knoxpod.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Copy link
Member

@cdkini cdkini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo 🎉 🎉 🎉

Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo 🎉 🎉 🎉

Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsherstinsky alexsherstinsky merged commit bbcab51 into develop Aug 6, 2021
@alexsherstinsky alexsherstinsky deleted the maintenance/GREAT-56/GREAT-90/alexsherstinsky/changelog_for_fix_of_incorrect_usage_of_all_in_validation_test_result_comparison-2021_08_06-42 branch August 6, 2021 18:52
Shinnnyshinshin pushed a commit that referenced this pull request Aug 9, 2021
* develop:
  [FEATURE] Update ExpectCompoundColumnsToBeUnique for V3 API (#3161)
  [DOCS] Add `conda` as installation option in README (#3196)
  [BUGFIX] Restore support for V2 API style custom expectation rendering (#3179)
  [BUGFIX] Fixes an error with expect_column_values_to_be_dateutil_parseable (#3190)
  [FEATURE] Set foundation for Azure-related DataConnectors (#3188)
  Update changelog. (#3189)
  Update validate_your_data.md (#3185)
  [BUGFIX] Fix incorrect usage of "all()" in the comparison of validation results when executing an Expectation (#3178)
  [BUGFIX] Remove fixture parameterization for Cloud DBs (Snowflake and BigQuery) (#3182)
  [DOCS] Update BigQuery docs to clarify the use of temp tables (#3184)
  [MAINTENANCE] Add `credentials` YAML key support for `DataConnectors` (#3173)
  release-prep-2021-08-05 (#3181)
  [DOCS] Improve Core Concepts - Expectation Concepts (#2831)
  Implement the "compound_columns_unique" metric for PandasExecutionEngine (with a unit test). (#3159)
  [FEATURE] Support row_condition and ignore_row_if Directives Combined for PandasExecutionEngine (#3150)
  Update test_script_runner.py (#3177)
  [DOCS] Capitalize python to Python in docs (#3176)
  [FEATURE] Update ExpectMulticolumnSumToEqual for V3 API (#3136)
mielvds pushed a commit to mielvds/great_expectations that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants