Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix deprecation warning for importing from collections #3228

Conversation

ismaildawoodjee
Copy link
Contributor

@ismaildawoodjee ismaildawoodjee commented Aug 12, 2021

This pull request fixes the deprecation warning that shows as a result of importing Iterable from collections instead of from collections.abc. Partly addresses Issue #3108

Changes proposed in this pull request:

  • Import Iterable from collections.abc instead of importing from collections

deprecation_warning

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Aug 12, 2021

👷 Deploy request for niobium-lead-7998 pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: c058e29

@cdkini cdkini self-assigned this Aug 12, 2021
@cdkini cdkini added community devrel This item is being addressed by the Developer Relations Team labels Aug 12, 2021
@cdkini
Copy link
Member

cdkini commented Aug 12, 2021

Hey @ismaildawoodjee great to see you back here again! We appreciate your contributions 😄

I'm happy to accept this but some of our integration tests are failing. I think this is unrelated to your PR so let me try and rerun to see if we can't get everything working as intended.

@cdkini cdkini enabled auto-merge (squash) August 12, 2021 12:18
@cdkini cdkini disabled auto-merge August 12, 2021 15:03
@cdkini
Copy link
Member

cdkini commented Aug 12, 2021

Quite confused as to why we're failing here. Please give us a bit of time to investigate further. Thanks!

@cdkini cdkini enabled auto-merge (squash) August 16, 2021 22:29
@cdkini
Copy link
Member

cdkini commented Aug 16, 2021

@ismaildawoodjee looks like the error had to do with permissions (forks wouldn't gather the necessary environment variables). Working together with @Shinnnyshinshin, we were able to resolve the issue!

Thanks so much for your patience and the continued help!

@cdkini cdkini merged commit 5b33a4c into great-expectations:develop Aug 17, 2021
@cdkini
Copy link
Member

cdkini commented Aug 17, 2021

Woohoo 🎉 🎉 🎉

Nice work @ismaildawoodjee

Shinnnyshinshin pushed a commit that referenced this pull request Aug 17, 2021
…r-expectations

* develop:
  [BUGFIX] Fix deprecation warning for importing from collections (#3228)
  [FEATURE] Add schema validation for different GCS auth methods (#3258)
@ismaildawoodjee
Copy link
Contributor Author

No worries Chetan. Thanks for the updates

@ismaildawoodjee ismaildawoodjee deleted the feature/fixing-deprecation-warning branch August 18, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants