-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix deprecation warning for importing from collections #3228
[BUGFIX] Fix deprecation warning for importing from collections #3228
Conversation
👷 Deploy request for niobium-lead-7998 pending review. 🔨 Explore the source changes: c058e29 |
Hey @ismaildawoodjee great to see you back here again! We appreciate your contributions 😄 I'm happy to accept this but some of our integration tests are failing. I think this is unrelated to your PR so let me try and rerun to see if we can't get everything working as intended. |
Quite confused as to why we're failing here. Please give us a bit of time to investigate further. Thanks! |
@ismaildawoodjee looks like the error had to do with permissions (forks wouldn't gather the necessary environment variables). Working together with @Shinnnyshinshin, we were able to resolve the issue! Thanks so much for your patience and the continued help! |
Woohoo 🎉 🎉 🎉 Nice work @ismaildawoodjee |
No worries Chetan. Thanks for the updates |
This pull request fixes the deprecation warning that shows as a result of importing
Iterable
fromcollections
instead of fromcollections.abc
. Partly addresses Issue #3108Changes proposed in this pull request:
Iterable
fromcollections.abc
instead of importing fromcollections
Definition of Done