[MAINTENANCE] Write integration/E2E tests for both GCSDataConnectors
#3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_to_pandas_execution_engine_to_facilitate_azure_connectors
…s_to_pandas_execution_engine_to_facilitate_azure_connectors
…for_gcs_data_connectors
…tions into FEATURE/GREAT-71/GREAT-81/implement_configured_asset_gcs_data_connector
…ion_tests_for_inferred_asset_gcs_data_connector
…inferred_asset_gcs_data_connector' of github.com:great-expectations/great_expectations into feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
…tions into feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
…tions into feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
…ecution_engine_to_facilitate_azure_connectors' into feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
cdkini
force-pushed
the
feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
branch
from
f0690f6
to
aa98dc3
Compare
cdkini
force-pushed
the
feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
branch
from
64d1265
to
991c79c
Compare
cdkini
commented
Aug 24, 2021
Comment on lines
+50
to
+57
| # "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/azure/pandas/inferred_and_runtime_yaml_example.py", | ||
| # "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| # }, | ||
| # { | ||
| # "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/azure/pandas/inferred_and_runtime_python_example.py", | ||
| # "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| # }, | ||
| # GCS |
There was a problem hiding this comment.
Segmenting by cloud provider and writing out the fixtures for the remaining Azure tests. If we like this, we could apply these changes to the S3 tests (once we've fixed them up!)
…ion_tests_for_inferred_asset_gcs_data_connector
Shinnnyshinshin
approved these changes
Aug 26, 2021
Comment on lines
+59
to
+73
| "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/gcs/pandas/configured_yaml_example.py", | ||
| "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| }, | ||
| { | ||
| "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/gcs/pandas/configured_python_example.py", | ||
| "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| }, | ||
| { | ||
| "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/gcs/pandas/inferred_and_runtime_yaml_example.py", | ||
| "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| }, | ||
| { | ||
| "user_flow_script": "tests/integration/docusaurus/connecting_to_your_data/cloud/gcs/pandas/inferred_and_runtime_python_example.py", | ||
| "data_context_dir": "tests/integration/fixtures/no_datasources/great_expectations", | ||
| }, |
There was a problem hiding this comment.
The fact that these will be running on Azure makes me very happy 😁
…ion_tests_for_inferred_asset_gcs_data_connector
cdkini
deleted the
feature/GREAT-71/GREAT-179/write_integration_tests_for_inferred_asset_gcs_data_connector
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 28, 2021
…data_context' into MAINTENANCE/GDOC-219/tests_datasource_sparkdf_pandas * MAINTENANCE/GDOC-2221/runtime_data_connector_sql_tests_data_context: after review [MAINTENANCE] Constructor for `BatchRequest` requires "triplet", and `RuntimeBatchRequest` also requires `runtime_parameters` and `batch_identifiers` (#3317) rename of methods to be more specific Release Prep release-prep-2021-08-26 (#3320) Docs] hide stubbed core skills (#3316) [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (#3301) [DOCS] Standardize capitalization of various technologies in `docs` (#3312) [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (#3315)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 28, 2021
…data_context' into MAINTENANCE/GDOC-222/tests_datacontext_sparkdf_pandas * MAINTENANCE/GDOC-2221/runtime_data_connector_sql_tests_data_context: after review [MAINTENANCE] Constructor for `BatchRequest` requires "triplet", and `RuntimeBatchRequest` also requires `runtime_parameters` and `batch_identifiers` (#3317) rename of methods to be more specific Release Prep release-prep-2021-08-26 (#3320) Docs] hide stubbed core skills (#3316) [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (#3301) [DOCS] Standardize capitalization of various technologies in `docs` (#3312) [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (#3315)
Shinnnyshinshin
pushed a commit
to jdimatteo/great_expectations
that referenced
this pull request
Aug 31, 2021
…matteo/great_expectations into feature/add_performance_test * 'feature/add_performance_test' of https://github.com/jdimatteo/great_expectations: [MAINTENANCE] Tests for RuntimeDataConnector at Datasource-level (Spark and Pandas) (great-expectations#3318) [MAINTENANCE] Tests for RuntimeDataConnector at DataContext-level (great-expectations#3304) [BUGFIX] SQL dialect doesn't register for BigQuery for V2 (great-expectations#3324) [WIP] [FEATURE] add backend args to run_diagnostics (great-expectations#3257) Release Prep release-prep-2021-08-26 (great-expectations#3320) Docs] hide stubbed core skills (great-expectations#3316) [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (great-expectations#3301) [DOCS] Standardize capitalization of various technologies in `docs` (great-expectations#3312) [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (great-expectations#3315) docs: Remove misc TODOs to tidy up docs (great-expectations#3313) [DOCS] GDOC-217 remove stub links (great-expectations#3314) [FEATURE] Enable `GCS DataConnector` integration with `PandasExecutionEngine` (great-expectations#3264)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
ConfiguredAssetGCSDataConnectorandInferredAssetGCSDataConnectorDefinition of Done
Please delete options that are not relevant.