Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix misc errors in "How to create renderers for Custom Expectations" #3315

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Aug 25, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Minor fix to Graph TabItem (please see the deployed build for reference)

@netlify
Copy link

netlify bot commented Aug 25, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: 28b23fa

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6126aa42779a1b0007b50391

😎 Browse the preview: https://deploy-preview-3315--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

@cdkini cdkini force-pushed the DOCS/fix_misc_errors_in_how_to_create_renderers_for_custom_expectations branch from 514abb8 to 70771a5 Compare August 25, 2021 20:27
@cdkini cdkini self-assigned this Aug 25, 2021
@cdkini
Copy link
Member Author

cdkini commented Aug 25, 2021

Screen Shot 2021-08-25 at 4 38 14 PM

@cdkini cdkini enabled auto-merge (squash) August 25, 2021 20:46
@cdkini
Copy link
Member Author

cdkini commented Aug 25, 2021

Screen Shot 2021-08-25 at 4 46 00 PM

@cdkini cdkini merged commit cd8a31b into develop Aug 25, 2021
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this earlier :) LGTM

@cdkini cdkini deleted the DOCS/fix_misc_errors_in_how_to_create_renderers_for_custom_expectations branch August 25, 2021 22:55
Shinnnyshinshin pushed a commit that referenced this pull request Aug 28, 2021
…data_context' into MAINTENANCE/GDOC-219/tests_datasource_sparkdf_pandas

* MAINTENANCE/GDOC-2221/runtime_data_connector_sql_tests_data_context:
  after review
  [MAINTENANCE] Constructor for `BatchRequest` requires "triplet", and `RuntimeBatchRequest` also requires `runtime_parameters` and `batch_identifiers` (#3317)
  rename of methods to be more specific
  Release Prep release-prep-2021-08-26 (#3320)
  Docs] hide stubbed core skills (#3316)
  [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (#3301)
  [DOCS] Standardize capitalization of various technologies in `docs` (#3312)
  [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (#3315)
Shinnnyshinshin pushed a commit that referenced this pull request Aug 28, 2021
…data_context' into MAINTENANCE/GDOC-222/tests_datacontext_sparkdf_pandas

* MAINTENANCE/GDOC-2221/runtime_data_connector_sql_tests_data_context:
  after review
  [MAINTENANCE] Constructor for `BatchRequest` requires "triplet", and `RuntimeBatchRequest` also requires `runtime_parameters` and `batch_identifiers` (#3317)
  rename of methods to be more specific
  Release Prep release-prep-2021-08-26 (#3320)
  Docs] hide stubbed core skills (#3316)
  [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (#3301)
  [DOCS] Standardize capitalization of various technologies in `docs` (#3312)
  [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (#3315)
Shinnnyshinshin pushed a commit to jdimatteo/great_expectations that referenced this pull request Aug 31, 2021
…matteo/great_expectations into feature/add_performance_test

* 'feature/add_performance_test' of https://github.com/jdimatteo/great_expectations:
  [MAINTENANCE] Tests for RuntimeDataConnector at Datasource-level (Spark and Pandas) (great-expectations#3318)
  [MAINTENANCE] Tests for RuntimeDataConnector at DataContext-level (great-expectations#3304)
  [BUGFIX] SQL dialect doesn't register for BigQuery for V2 (great-expectations#3324)
  [WIP] [FEATURE] add backend args to run_diagnostics (great-expectations#3257)
  Release Prep release-prep-2021-08-26 (great-expectations#3320)
  Docs] hide stubbed core skills (great-expectations#3316)
  [MAINTENANCE] Write integration/E2E tests for both `GCSDataConnectors` (great-expectations#3301)
  [DOCS] Standardize capitalization of various technologies in `docs` (great-expectations#3312)
  [DOCS] Fix misc errors in "How to create renderers for Custom Expectations" (great-expectations#3315)
  docs: Remove misc TODOs to tidy up docs (great-expectations#3313)
  [DOCS] GDOC-217 remove stub links (great-expectations#3314)
  [FEATURE] Enable `GCS DataConnector` integration with `PandasExecutionEngine` (great-expectations#3264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants