Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] g_e docs branding updates #3471

Merged
merged 7 commits into from
Oct 1, 2021

Conversation

OrtalG
Copy link
Contributor

@OrtalG OrtalG commented Sep 30, 2021

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Update g_e docs branding to be more in line with the new greatexpectations.io

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: 229ea21

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/6157517add64b50008bc4ddd

😎 Browse the preview: https://deploy-preview-3471--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

Copy link
Member

@abegong abegong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting in sidebars.js lgtm. :)

@OrtalG OrtalG merged commit d2bcb4c into develop Oct 1, 2021
@OrtalG OrtalG deleted the maintenance/docusaurus_branding_updates branch October 1, 2021 18:47
Shinnnyshinshin pushed a commit that referenced this pull request Oct 7, 2021
* develop:
  Support SQLAlchemy version 1.3.24 for compatibility with Airflow (Airflow does not currently support later versions of SQLAlchemy). (#3499)
  [DOCS] Adding Flyte Deployment pattern to docs (#3383)
  [FEATURE] add get_available_data_asset_names_and_types (#3476)
  update implemented_expectations (#3492)
  Clean up for a better code readability. (#3493)
  [MAINTENANCE] Fix some typos (#3474)
  [BUGFIX] Fix TupleS3StoreBackend remove_key bug (#3489)
  Enable SQL for the "expect_compound_columns_to_be_unique" expectation. (#3488)
  [FEATURE] Implement CompoundColumnsUnique metric for SqlAlchemyExecutionEngine (#3477)
  Update how_to_configure_a_validation_result_store_in_gcs.md (#3480)
  Update contributing_checklist.md (#3478)
  [MAINTENANCE] Add type-hints; add utility method for creating temporary DB tables; clean up imports; improve code readability; and add a directory to pre-commit (#3475)
  [DOCS] g_e docs branding updates (#3471)
  [FEATURE] add s3_put_options to TupleS3StoreBackend (#3470)
  release-prep-2021-09-30 (#3472)
  [MAINTENANCE] Remove validation playground notebooks (#3467)
  Does not test numpy.float128 when it doesn't exist (#3460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants