Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix pyfakefs boto / GCS incompatibility #3694

Merged

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: 89f5da5

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61952e1e07ff490007f81fb0

😎 Browse the preview: https://deploy-preview-3694--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

@anthonyburdi anthonyburdi enabled auto-merge (squash) November 17, 2021 16:34
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, such a subtle bug.. thank you so much @anthonyburdi

@anthonyburdi anthonyburdi merged commit 43da163 into develop Nov 17, 2021
@anthonyburdi anthonyburdi deleted the BUGFIX/none/GREAT-389/fix_pyfakefs_boto_incompatibility branch November 17, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants