Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Minor tweak to the link to MetricStore link #3714

Merged
merged 4 commits into from
Nov 20, 2021

Conversation

txblackbird
Copy link
Contributor

@txblackbird txblackbird commented Nov 19, 2021

The previous fix to the link didn't resolve properly. Adding an additional upstream folder change to get to the correct path. This should get it to /docs/guides/setup/configuring_metadata_stores/how_to_configure_a_metricsstore.md as expected.

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:
-The previous fix to the link didn't resolve properly. Adding an additional upstream folder change to get to the correct path.

After submitting your PR, CI checks will run and @tiny-tim-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation

Thank you for submitting!

The previous fix to the link didn't resolve properly.  Adding an additional upstream folder change to get to the correct path.  This should get it to /docs/guides/setup/configuring_metadata_stores/how_to_configure_a_metricsstore.md as expected.
@netlify
Copy link

netlify bot commented Nov 19, 2021

👷 Deploy request for niobium-lead-7998 pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: d14f608

@txblackbird
Copy link
Contributor Author

The previous link change was not exactly accurate. This tweak should resolve the issue by correcting the link location.

@cdkini cdkini enabled auto-merge (squash) November 20, 2021 17:22
@cdkini cdkini merged commit 2a3791c into great-expectations:develop Nov 20, 2021
@txblackbird txblackbird deleted the patch-2 branch November 22, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants