Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove DeprecationWarning for validator.remove_expectation #3744

Merged

Conversation

talagluck
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • After design review yesterday, it is apparent that currently the most appropriate way to remove an expectation in V3 is to call validator.remove_expectation. However, this throws an erroneous DeprecationWarning.

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: b9b21cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/619e721778ca0a0008d5af10

😎 Browse the preview: https://deploy-preview-3744--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

Thank you!

…tion' of github.com:great-expectations/great_expectations into remove_deprecation_warning_for_validator.remove_expectation
@talagluck talagluck enabled auto-merge (squash) November 24, 2021 16:10
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @talagluck . Approving again for good measure :)

@talagluck talagluck merged commit 3376bbe into develop Nov 24, 2021
@talagluck talagluck deleted the remove_deprecation_warning_for_validator.remove_expectation branch November 24, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants