Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Ensure proper exit code for dependency graph script #3839

Merged
merged 7 commits into from Dec 13, 2021
Merged

[BUGFIX] Ensure proper exit code for dependency graph script #3839

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7ccc74
fix: Add EXIT_STATUS var to pipeline scripts
cdkini Dec 12, 2021
8fc8000
misc: Test change
cdkini Dec 12, 2021
f282051
misc: Revert changes
cdkini Dec 12, 2021
9f86996
Merge branch 'develop' of github.com:great-expectations/great_expecta…
cdkini Dec 13, 2021
bd62784
docs: Add comments in pipeline YAML
cdkini Dec 13, 2021
a270a4f
chore: Revert test changes
cdkini Dec 13, 2021
a14e20a
Merge branch 'develop' into bugfix/ensure-proper-exit-code-for-depend…
cdkini Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
50 changes: 50 additions & 0 deletions azure-pipelines-dependency-graph-testing.yml
View file
Open in desktop
Expand Up @@ -147,13 +147,23 @@ stages:
displayName: 'Install dependencies'

- script: |
# Install dependencies
pip install pytest pytest-cov pytest-azurepipelines

# Run script and save output to a temp file
echo "Tests identified by dependency graph test runner [dgtest]:"
python scripts/determine_tests_to_run.py --depth 3 --ignore 'tests/cli' 'tests/integration/usage_statistics' | tee .dgtest

# If the script found any matches, feed them into pytest
EXIT_STATUS=0
if [ -s .dgtest ]; then
cat .dgtest | xargs pytest $(GE_pytest_opts) --napoleon-docstrings --junitxml=junit/test-results.xml --cov=. --cov-report=xml --cov-report=html
EXIT_STATUS=$?
fi

# Clean up
rm .dgtest
exit $EXIT_STATUS
displayName: 'pytest'

- task: PublishTestResults@2
Expand Down Expand Up @@ -214,13 +224,23 @@ stages:
displayName: 'Install dependencies'

- script: |
# Install dependencies
pip install pytest pytest-cov pytest-azurepipelines

# Run script and save output to a temp file
echo "Tests identified by dependency graph test runner [dgtest]:"
python scripts/determine_tests_to_run.py --depth 3 --ignore 'tests/cli' 'tests/integration/usage_statistics' | tee .dgtest

# If the script found any matches, feed them into pytest
EXIT_STATUS=0
if [ -s .dgtest ]; then
cat .dgtest | xargs pytest $(GE_pytest_opts) --napoleon-docstrings --junitxml=junit/test-results.xml --cov=. --cov-report=xml --cov-report=html
EXIT_STATUS=$?
fi

# Clean up
rm .dgtest
exit $EXIT_STATUS
displayName: 'pytest'

- task: PublishTestResults@2
Expand Down Expand Up @@ -280,14 +300,24 @@ stages:
displayName: 'Install dependencies'

- script: |
# Install dependencies
pip install --requirement requirements.txt
pip install pytest pytest-cov pytest-azurepipelines

# Run script and save output to a temp file
echo "Tests identified by dependency graph test runner [dgtest]:"
python scripts/determine_tests_to_run.py --depth 3 --ignore 'tests/cli' 'tests/integration/usage_statistics' | tee .dgtest

# If the script found any matches, feed them into pytest
EXIT_STATUS=0
if [ -s .dgtest ]; then
cat .dgtest | xargs pytest --mysql --no-postgresql --no-spark --napoleon-docstrings --junitxml=junit/test-results.xml --cov=. --cov-report=xml --cov-report=html
EXIT_STATUS=$?
fi

# Clean up
rm .dgtest
exit $EXIT_STATUS
displayName: 'pytest'

- job: mssql
Expand Down Expand Up @@ -318,13 +348,23 @@ stages:
displayName: 'Install dependencies'

- script: |
# Install dependencies
pip install pytest pytest-cov pytest-azurepipelines

# Run script and save output to a temp file
echo "Tests identified by dependency graph test runner [dgtest]:"
python scripts/determine_tests_to_run.py --depth 3 --ignore 'tests/cli' 'tests/integration/usage_statistics' | tee .dgtest

# If the script found any matches, feed them into pytest
EXIT_STATUS=0
if [ -s .dgtest ]; then
cat .dgtest | xargs pytest --mssql --no-postgresql --no-spark --napoleon-docstrings --junitxml=junit/test-results.xml --cov=. --cov-report=xml --cov-report=html
EXIT_STATUS=$?
fi

# Clean up
rm .dgtest
exit $EXIT_STATUS
displayName: 'pytest'

- stage: cli_integration
Expand Down Expand Up @@ -363,11 +403,21 @@ stages:
displayName: 'Install dependencies'

- script: |
# Install dependencies
pip install pytest pytest-azurepipelines

# Run script and save output to a temp file
echo "Tests identified by dependency graph test runner [dgtest]:"
python scripts/determine_tests_to_run.py --filter 'tests/cli' --depth 3 | tee .dgtest

# If the script found any matches, feed them into pytest
EXIT_STATUS=0
if [ -s .dgtest ]; then
cat .dgtest | xargs pytest --aws-integration -v
EXIT_STATUS=$?
fi

# Clean up
rm .dgtest
exit $EXIT_STATUS
displayName: 'pytest'