[FEATURE] great_expectations_contrib CLI tool
#3909
Conversation
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: 978c0dc 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61cc81d61fee12000830e7d4 😎 Browse the preview: https://deploy-preview-3909--niobium-lead-7998.netlify.app |
HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖Please don't forget to add a clear and succinct description of your change under the Develop header in ✨ Thank you! ✨ |
There was a problem hiding this comment.
Quick review: https://www.loom.com/share/ffbda62cce7d4b1e8b5b26ba6f285326
Nonblocking issues to consider:
- Let’s be cautious about defaults. I’ll defer to @talagluck and the DevRel team on this.
- How can we strongly incline people to use our preferred
*_expectationsnaming convention? - The cookiecutter template will need some changes and updates.
- The directory structure needs updating
requirements.devshould havegreat_expectationsas a dependency- Other changes to fit in with our CI + pypi deployment pipeline.
…tions into feature/great_expectations_contrib-cli-tool
| from great_expectations_contrib.commands import check_cmd, init_cmd, publish_cmd | ||
|
|
||
| # The following link points to the repo where the Cookiecutter template is hosted | ||
| URL = "https://github.com/great-expectations/great-expectations-contrib-cookiecutter" |
| return is_successful | ||
|
|
||
|
|
||
| def publish_to_pypi() -> None: |
There was a problem hiding this comment.
Silly question - is there any security risk here? Just double checking that someone couldn't accidentally publish something that they didn't mean to publish.
There was a problem hiding this comment.
great question! perhaps we want to get rid of this and just let the user go through the steps manually? it's easy enough to remove this if need be I'm really not too sure of the security implications
There was a problem hiding this comment.
Aside from the inline comments, do we want to check that the user has a ~/.pypirc file before proceeding? Even though twine is a part of the requirements, I think it will fail to publish to pypi.org if there is not a ~/.pypirc file.
And to Abe's point about ensuring the project_name ends with "Expectations" and the project_slug ends with _expectations, do we want to inspect the string and append automatically if they don't have it?
…tions into feature/great_expectations_contrib-cli-tool
|
@kenwade4 sorry just seeing your comments outside of the code. I'm not too familiar with packaging so if you think I think I'll bring up this command during arch review to discuss the possible security implications @talagluck brought up. In regards to the naming conventions, Cookiecutter has input validation so we can add custom logic to reject a user's project if they don't append Expectations. |
|
If twine will prompt the user for their pypi creds if there is no pypirc file, that's probably good enough. |
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!