Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove types/expectations.py #3928

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Remove types/expectations.py #3928

merged 3 commits into from
Jan 3, 2022

Conversation

abegong
Copy link
Member

@abegong abegong commented Jan 1, 2022

Changes proposed in this pull request:

  • Delete an unused file

@netlify
Copy link

netlify bot commented Jan 1, 2022 •
edited
Loading

✔️ Deploy Preview for niobium-lead-7998 ready!

🔨 Explore the source changes: f14972e

🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61d38452f300a400083b2901

😎 Browse the preview: https://deploy-preview-3928--niobium-lead-7998.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2022

HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖

Please don't forget to add a clear and succinct description of your change under the Develop header in docs_rtd/changelog.rst, if applicable. This will help us with the release process. See the Contribution checklist in the Great Expectations documentation for the type of labels to use!

✨ Thank you! ✨

alexsherstinsky
alexsherstinsky approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming checks pass).

Shinnnyshinshin
Shinnnyshinshin approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@abegong abegong merged commit 24befd2 into develop Jan 3, 2022
@abegong abegong deleted the cleanup/remove-types-expectations-file branch January 3, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsherstinsky alexsherstinsky alexsherstinsky approved these changes

@donaldheppner donaldheppner donaldheppner approved these changes

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abegong @alexsherstinsky @donaldheppner @Shinnnyshinshin