[DOCS][BUGFIX] Make corrections in HOWTO Guides for Getting Data from SQL Sources #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 5, 2022 08:24
…default_cli_flag_to_v3-2022_01_04-34
…default_cli_flag_to_v3-2022_01_04-34
…default_cli_flag_to_v3-2022_01_04-34
…ading_sql_cli_create_suite_documentation-2022_01_05-35
|
✔️ Deploy Preview for niobium-lead-7998 ready! 🔨 Explore the source changes: 70e163d 🔍 Inspect the deploy log: https://app.netlify.com/sites/niobium-lead-7998/deploys/61d669e04e618e0007eda776 😎 Browse the preview: https://deploy-preview-3945--niobium-lead-7998.netlify.app |
HOWDY! This is your friendly 🤖 CHANGELOG bot 🤖Please don't forget to add a clear and succinct description of your change under the Develop header in ✨ Thank you! ✨ |
alexsherstinsky
requested review from
Shinnnyshinshin,
NathanFarmer,
cdkini,
anthonyburdi,
donaldheppner and
Rachel-Reverie
…ading_sql_cli_create_suite_documentation-2022_01_05-35
…ipt' into docs/DEVREL-380/alexsherstinsky/fix_misleading_sql_cli_create_suite_documentation-2022_01_05-35
…ading_sql_cli_create_suite_documentation-2022_01_05-35
Shinnnyshinshin
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Looks wonderful. Thank you for the discussions around this @alexsherstinsky and @cdkini
alexsherstinsky
deleted the
docs/DEVREL-380/alexsherstinsky/fix_misleading_sql_cli_create_suite_documentation-2022_01_05-35
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jan 11, 2022
…ues-to-be-in-set * develop: [DOCS] Connecting to BigQuery Doc line references fix #3974 [DOCS] Note about creating backup of Checkpoints (#3968) Incremental Update: The Universal Map's Getting Started Tutorial (#3881) [DOCS] MigrationGuide - Adding note on Migrating Expectation Suites (#3959) enable mssql docs. tests are already being run (#3950) chore: remove old files (#3953) [MAINTENANCE] Use Effective SQLAlchemy for Reflection Fallback Logic and SQL Metrics (#3958) [MAINTENANCE] Refactor docs dependency script (#3952) [BUGFIX] Safeguard against using V2 API with V3 Configuration (#3954) release candidate for 0.14.0 (#3956) Update migration guide (#3955) Fix issue where meta was not recognized as a kwarg (#3852) [DOCS][BUGFIX] Make corrections in HOWTO Guides for Getting Data from SQL Sources (#3945) fix: add fix (#3949) Tiny doc fix (#3948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!