[DOCS] Fix relative links on github #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix relative links on github This commit fixes relative links returning '404' error when accessed on https://github.com/great-expectations/great_expectations.
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
austiezr
suggested changes
Mar 21, 2022
There was a problem hiding this comment.
Awesome to see this come in; thank you so much @andyjessen !
I've noted out places where the updated links are broken; otherwise love to see this. 🚀
...deployment_patterns/how_to_use_great_expectations_with_google_cloud_platform_and_bigquery.md
Outdated
Show resolved
Hide resolved
Comment on lines
100
to
105
| For more advanced configurations of Checkpoints, please see [How to configure a new Checkpoint using test_yaml_config](../../../guides/validation/checkpoints/how_to_configure_a_new_checkpoint_using_test_yaml_config.md). | ||
|
|
||
| ### Additional Resources | ||
|
|
||
| * [How to configure a new Checkpoint using test_yaml_config](/docs/guides/validation/checkpoints/how_to_configure_a_new_checkpoint_using_test_yaml_config) | ||
| * [How to add validations data or suites to a Checkpoint](/docs/guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint) | ||
| * [How to configure a new Checkpoint using test_yaml_config](../../../guides/validation/checkpoints/how_to_configure_a_new_checkpoint_using_test_yaml_config.md) | ||
| * [How to add validations data or suites to a Checkpoint](../../../guides/validation/checkpoints/how_to_add_validations_data_or_suites_to_a_checkpoint.md) |
There was a problem hiding this comment.
I couldn't get suggested path to work.
There was a problem hiding this comment.
My bad; looks like these should be ./<file_name>
...lidation/validation_actions/how_to_collect_openlineage_metadata_using_a_validation_action.md
Outdated
Show resolved
Hide resolved
austiezr
added
community
devrel
austiezr
suggested changes
Mar 22, 2022
Comment on lines
327
to
328
| 1. [Running a Checkpoint in Airflow using a `bash operator`](./how_to_use_great_expectations_with_airflow#option-1-running-a-checkpoint-with-a-bashoperator.md) | ||
| 2. [Running a Checkpoint in Airflow using a `python operator`](./how_to_use_great_expectations_with_airflow#option-2-running-the-checkpoint-script-output-with-a-pythonoperator.md) |
There was a problem hiding this comment.
I fixed link in new commit.
| @@ -451,14 +451,14 @@ You've successfully migrated your Great Expectations configuration to Cloud Comp | |||
|
|
|||
| There are many ways to iterate and improve this initial version, which used a `bash operator` for simplicity. For information on more sophisticated ways of triggering Checkpoints, building our DAGs, and dividing our Data Assets into Batches using DataConnectors, please refer to the following documentation: | |||
|
|
|||
| - [How to run a Checkpoint in Airflow using a `python operator`](/docs/deployment_patterns/how_to_use_great_expectations_with_airflow#option-2-running-the-checkpoint-script-output-with-a-pythonoperator). | |||
| - [How to run a Checkpoint in Airflow using a `python operator`](./how_to_use_great_expectations_with_airflow#option-2-running-the-checkpoint-script-output-with-a-pythonoperator.md). | |||
There was a problem hiding this comment.
I fixed link in new commit.
There was a problem hiding this comment.
Hey @andyjessen ! I'm not seeing the latest commit re: above.
There was a problem hiding this comment.
Thanks @austiezr for catching my mistake. (I made commit on separate branch that got pruned.) I added to current branch and pushed.
Hi @austiezr - I fixed links. I noticed another broken path in same file and fixed it as well. |
fjork3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes relative links returning '404' error when accessed on https://github.com/great-expectations/great_expectations.
Definition of Done
Please delete options that are not relevant.