Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENENANCE] Add compatability stage to dependency_graph pipeline #4514

Merged
merged 3 commits into from
Mar 23, 2022
Merged

[MAINTENENANCE] Add compatability stage to dependency_graph pipeline #4514

merged 3 commits into from
Mar 23, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Mar 23, 2022

Changes proposed in this pull request:

  • This stage used to be part of this pipeline was but was removed so we could eek out some performance improvements.
  • Some errors have slipped through in the past few weeks as a result of this so it makes sense to enforce the stage once again.

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Mar 23, 2022 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 39c6992
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/623b1579e5cbf80009baca66
😎 Deploy Preview https://deploy-preview-4514--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cdkini cdkini self-assigned this Mar 23, 2022
talagluck
talagluck approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@talagluck talagluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdkini cdkini merged commit b6f4f94 into develop Mar 23, 2022
@cdkini cdkini deleted the maintenance/add-back-in-compatability-stage-to-dgtest-pipeline branch March 23, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldheppner donaldheppner donaldheppner approved these changes

@talagluck talagluck talagluck approved these changes

Assignees

@cdkini cdkini

Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdkini @donaldheppner @talagluck