Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACKATHON] ExpectColumnValuesToBeValidIanaTimezone #4532

Merged
merged 4 commits into from
Mar 24, 2022
Merged

[HACKATHON] ExpectColumnValuesToBeValidIanaTimezone #4532

merged 4 commits into from
Mar 24, 2022

Conversation

lucasasmith
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Add expectation for checking validity of a column of timezone strings.

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Mar 24, 2022

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8a3d114

Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasasmith Thanks for your submission! Great to see this come in. Be sure to link this PR in your DevPost submission as well. 🚀

@austiezr
Copy link
Contributor

austiezr commented Mar 24, 2022

@cla-bot check

@austiezr austiezr enabled auto-merge (squash) March 24, 2022 17:12
@austiezr austiezr merged commit 50fa58d into great-expectations:develop Mar 24, 2022
@austiezr austiezr added community devrel This item is being addressed by the Developer Relations Team hackathon-2022 labels Apr 5, 2022
@lucasasmith lucasasmith deleted the hackathon/valid_timezone branch April 11, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community devrel This item is being addressed by the Developer Relations Team hackathon-2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants