Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HACKATHON] add icd10 regex expectation #4691

Merged
merged 2 commits into from Apr 8, 2022
Merged

[HACKATHON] add icd10 regex expectation #4691

merged 2 commits into from Apr 8, 2022

Conversation

zachlindsey
Copy link
Contributor

Changes proposed in this pull request:

  • Add a simple regex that checks if the values in the column are of the correct format to be ICD10 codes.

Definition of Done

Please delete options that are not relevant.

  • [X ] My code follows the Great Expectations style guide
  • [ X] I have performed a self-review of my own code
  • [ X] I have commented my code, particularly in hard-to-understand areas

Thank you for submitting!

@netlify
Copy link

netlify bot commented Apr 5, 2022 •
edited

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0faf563

@austiezr austiezr added community devrel This item is being addressed by the Developer Relations Team hackathon-2022 labels Apr 8, 2022
austiezr
austiezr approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @zachlindsey !

@austiezr austiezr enabled auto-merge (squash) April 8, 2022 20:29
@austiezr austiezr merged commit 7b3217b into great-expectations:develop Apr 8, 2022
Shinnnyshinshin pushed a commit that referenced this pull request Apr 11, 2022
Merge branch 'develop' of https://github.com/great-expectations/great…
3b87654 
…_expectations into develop

* 'develop' of https://github.com/great-expectations/great_expectations: (39 commits)
  Fix links within datasource new notebook (#4833)
  Modify conditional expectations readme (#4616)
  Cleanup contrib (#4838)
  Resubmission of 4 geospatial expectations. (#4836)
  [BUGFIX] Changes `parse_strings_as_datetimes` in UserConfigurableProfiler to default to False (#4501)
  Fix Typo in Checkpoint Readme (#4835)
  [HACKATHON] Add ExpectColumnMiminumBoundingRadiusToBeBetween  (#4688)
  [HACKATHON] ExpectColumnValuesReverseGeocodedLatLonToContain expectation (#4807)
  add expect_column_values_bitcoin_tx_is_confirmed (#4778)
  [HACKATHON] ExpectColumnValuesToBeValidCurrencyCode (#4580)
  [HACKATHON] add expect_column_values_to_be_valid_tld (#4630)
  [HACKATHON] ExpectColumnValuesToBeGtinBaseUnit (#4781)
  [HACKATHON] Added ExpectColumnValuesToBeNonemptyGeometries (#4806)
  [HACKATHON] Added ExpectColumnValuesGeometryToBeOfType (#4805)
  add expect_column_values_to_be_gtin_variable_measure_trade_item (#4782)
  add expect_column_values_to_be_valid_formatted_vat (#4784)
  [FEATURE] Expect column values to be http method (#4690)
  add icd10 regex expectation (#4691)
  add expect_column_values_to_be_valid_vies_vat (#4785)
  add expect_column_values_to_be_valid_mic_match_country_code (#4787)
  ...
Shinnnyshinshin pushed a commit that referenced this pull request Apr 11, 2022
Merge branch 'develop' into feature/CLOUD-839/GREAT-767/runtime-data-…
bf2cacc 
…connector-assets-added

* develop: (39 commits)
  Fix links within datasource new notebook (#4833)
  Modify conditional expectations readme (#4616)
  Cleanup contrib (#4838)
  Resubmission of 4 geospatial expectations. (#4836)
  [BUGFIX] Changes `parse_strings_as_datetimes` in UserConfigurableProfiler to default to False (#4501)
  Fix Typo in Checkpoint Readme (#4835)
  [HACKATHON] Add ExpectColumnMiminumBoundingRadiusToBeBetween  (#4688)
  [HACKATHON] ExpectColumnValuesReverseGeocodedLatLonToContain expectation (#4807)
  add expect_column_values_bitcoin_tx_is_confirmed (#4778)
  [HACKATHON] ExpectColumnValuesToBeValidCurrencyCode (#4580)
  [HACKATHON] add expect_column_values_to_be_valid_tld (#4630)
  [HACKATHON] ExpectColumnValuesToBeGtinBaseUnit (#4781)
  [HACKATHON] Added ExpectColumnValuesToBeNonemptyGeometries (#4806)
  [HACKATHON] Added ExpectColumnValuesGeometryToBeOfType (#4805)
  add expect_column_values_to_be_gtin_variable_measure_trade_item (#4782)
  add expect_column_values_to_be_valid_formatted_vat (#4784)
  [FEATURE] Expect column values to be http method (#4690)
  add icd10 regex expectation (#4691)
  add expect_column_values_to_be_valid_vies_vat (#4785)
  add expect_column_values_to_be_valid_mic_match_country_code (#4787)
  ...
@fjork3 fjork3 changed the title [FEATURE] add icd10 regex expectation [HACKATHON] add icd10 regex expectation Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austiezr austiezr austiezr approved these changes

Assignees
No one assigned
Labels
community devrel This item is being addressed by the Developer Relations Team hackathon-2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zachlindsey @austiezr