Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HACKATHON] ExceptColumnValuesToBeValidMicMatchCountryCode #4787

Conversation

szecsip
Copy link
Contributor

@szecsip szecsip commented Apr 6, 2022

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Adds a new Expectation to validate that column values to be valid MIC (Market Identifier Code) code belong to country which alpha-2 code passed in parameter.

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Apr 6, 2022

👷 Deploy request for niobium-lead-7998 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e33bc4d

@austiezr austiezr added community devrel This item is being addressed by the Developer Relations Team hackathon-2022 labels Apr 8, 2022
Copy link
Contributor

@austiezr austiezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @szecsip! 🚀

@austiezr austiezr enabled auto-merge (squash) April 8, 2022 17:33
@austiezr austiezr merged commit 137169c into great-expectations:develop Apr 8, 2022
Shinnnyshinshin pushed a commit that referenced this pull request Apr 11, 2022
…_expectations into develop

* 'develop' of https://github.com/great-expectations/great_expectations: (39 commits)
  Fix links within datasource new notebook (#4833)
  Modify conditional expectations readme (#4616)
  Cleanup contrib (#4838)
  Resubmission of 4 geospatial expectations. (#4836)
  [BUGFIX] Changes `parse_strings_as_datetimes` in UserConfigurableProfiler to default to False (#4501)
  Fix Typo in Checkpoint Readme (#4835)
  [HACKATHON] Add ExpectColumnMiminumBoundingRadiusToBeBetween  (#4688)
  [HACKATHON] ExpectColumnValuesReverseGeocodedLatLonToContain expectation (#4807)
  add expect_column_values_bitcoin_tx_is_confirmed (#4778)
  [HACKATHON] ExpectColumnValuesToBeValidCurrencyCode (#4580)
  [HACKATHON] add expect_column_values_to_be_valid_tld (#4630)
  [HACKATHON] ExpectColumnValuesToBeGtinBaseUnit (#4781)
  [HACKATHON] Added ExpectColumnValuesToBeNonemptyGeometries (#4806)
  [HACKATHON] Added ExpectColumnValuesGeometryToBeOfType (#4805)
  add expect_column_values_to_be_gtin_variable_measure_trade_item (#4782)
  add expect_column_values_to_be_valid_formatted_vat (#4784)
  [FEATURE] Expect column values to be http method (#4690)
  add icd10 regex expectation (#4691)
  add expect_column_values_to_be_valid_vies_vat (#4785)
  add expect_column_values_to_be_valid_mic_match_country_code (#4787)
  ...
Shinnnyshinshin pushed a commit that referenced this pull request Apr 11, 2022
…connector-assets-added

* develop: (39 commits)
  Fix links within datasource new notebook (#4833)
  Modify conditional expectations readme (#4616)
  Cleanup contrib (#4838)
  Resubmission of 4 geospatial expectations. (#4836)
  [BUGFIX] Changes `parse_strings_as_datetimes` in UserConfigurableProfiler to default to False (#4501)
  Fix Typo in Checkpoint Readme (#4835)
  [HACKATHON] Add ExpectColumnMiminumBoundingRadiusToBeBetween  (#4688)
  [HACKATHON] ExpectColumnValuesReverseGeocodedLatLonToContain expectation (#4807)
  add expect_column_values_bitcoin_tx_is_confirmed (#4778)
  [HACKATHON] ExpectColumnValuesToBeValidCurrencyCode (#4580)
  [HACKATHON] add expect_column_values_to_be_valid_tld (#4630)
  [HACKATHON] ExpectColumnValuesToBeGtinBaseUnit (#4781)
  [HACKATHON] Added ExpectColumnValuesToBeNonemptyGeometries (#4806)
  [HACKATHON] Added ExpectColumnValuesGeometryToBeOfType (#4805)
  add expect_column_values_to_be_gtin_variable_measure_trade_item (#4782)
  add expect_column_values_to_be_valid_formatted_vat (#4784)
  [FEATURE] Expect column values to be http method (#4690)
  add icd10 regex expectation (#4691)
  add expect_column_values_to_be_valid_vies_vat (#4785)
  add expect_column_values_to_be_valid_mic_match_country_code (#4787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community devrel This item is being addressed by the Developer Relations Team hackathon-2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants