Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixes import statement. #4694

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

rdodev
Copy link
Contributor

@rdodev rdodev commented Apr 5, 2022

Thanks to David Walling (via Slack) for heads up.

Changes proposed in this pull request:

  • Changes import statement

After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label Apr 5, 2022
@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 338116c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/624c8521260351000894d367
😎 Deploy Preview https://deploy-preview-4694--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rdodev rdodev enabled auto-merge (squash) April 5, 2022 18:06
@rdodev rdodev merged commit 4fdd442 into develop Apr 5, 2022
@rdodev rdodev deleted the data-context-import-statement branch April 5, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants