[FEATURE] DataAssistantResult Includes Underlying Profiler Execution Time #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 12, 2022 13:58
…ky/rule_based_profiler/data_assistant_result_should_include_profiler_run_duration-2022_04_12-90
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alexsherstinsky
requested review from
cdkini,
Shinnnyshinshin and
donaldheppner
Shinnnyshinshin
approved these changes
Apr 13, 2022
great_expectations/rule_based_profiler/data_assistant/data_assistant.py
Outdated
Show resolved
Hide resolved
tests/rule_based_profiler/data_assistant/test_volume_data_assistant.py
Outdated
Show resolved
Hide resolved
added 5 commits
April 12, 2022 18:52
…ky/rule_based_profiler/data_assistant_result_should_include_profiler_run_duration-2022_04_12-90
alexsherstinsky
deleted the
feature/GREAT-735/GREAT-783/alexsherstinsky/rule_based_profiler/data_assistant_result_should_include_profiler_run_duration-2022_04_12-90
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Apr 13, 2022
…_expectations into develop * 'develop' of https://github.com/great-expectations/great_expectations: [FEATURE] DataAssistantResult Includes Underlying Profiler Execution Time (#4854) [MAINTENANCE] Refactor `Datasource` tests that work with `RuntimeDataConnector` by backend. (#4853) [MAINTENANCE] Update testing and documentation for `oneshot` estimation method (#4852) Use engine.dialect.name instead of dialect.name (#4476) Fix bug in unexpected count metric for empty tables (#4618) [FEATURE] Add Support for Returning Parameters and Metrics as DataAssistantResult class (#4848) [DOCS] Add example to expectation docstring (#4341) - Adds redirect for legacy doc that was overlooked in the original redirects list (closes DEVREL-1866) (#4846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
measure_execution_timeutility (developed a significant time ago) to call back with results (not just print).@measure_execution_timeon running profiler forDataAssetclasses.DataAssistantResult.execution_timein test ofVolumeDataAssistantsubclass.Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @ge-cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!