[FEATURE] OnboardingDataAssistantResult plotting feature parity with VolumeDataAssistantResult #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…ta-assistant-table-plots
…ta-assistant-table-plots
…ta-assistant-table-plots
NathanFarmer
requested review from
alexsherstinsky,
Shinnnyshinshin,
anthonyburdi,
cdkini and
donaldheppner
cdkini
reviewed
May 19, 2022
great_expectations/rule_based_profiler/types/data_assistant_result/data_assistant_result.py
Show resolved
Hide resolved
great_expectations/rule_based_profiler/types/data_assistant_result/data_assistant_result.py
Show resolved
Hide resolved
great_expectations/rule_based_profiler/types/data_assistant_result/data_assistant_result.py
Show resolved
Hide resolved
...ctations/rule_based_profiler/types/data_assistant_result/onboarding_data_assistant_result.py
Show resolved
Hide resolved
tests/rule_based_profiler/data_assistant/test_onboarding_data_assistant.py
Show resolved
Hide resolved
| ): | ||
| context: DataContext = bobby_columnar_table_multi_batch_deterministic_data_context | ||
|
|
||
| theme = {"font": "Comic Sans MS"} |
tests/rule_based_profiler/data_assistant/test_onboarding_data_assistant.py
Show resolved
Hide resolved
…ta-assistant-table-plots
...expectations/rule_based_profiler/types/data_assistant_result/volume_data_assistant_result.py
Show resolved
Hide resolved
alexsherstinsky
suggested changes
May 20, 2022
There was a problem hiding this comment.
@NathanFarmer just requesting the type hints (OK otherwise) -- thank you!
added 2 commits
May 20, 2022 09:20
…able-plots' of github.com:great-expectations/great_expectations into feature/GREAT-761/GREAT-847/onboarding-data-assistant-table-plots
added 2 commits
May 20, 2022 09:33
cdkini
approved these changes
May 20, 2022
NathanFarmer
deleted the
feature/GREAT-761/GREAT-847/onboarding-data-assistant-table-plots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
VolumeDataAssistantResultin preparation forOnboardingDataAssistantResultplottingDataAssistantResultallowing for thin wrapper at child class levelDefinition of Done