Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] update on availability and parameters of conditional expectations #5150

Conversation

Rachel-Reverie
Copy link
Contributor

Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.

Changes proposed in this pull request:

  • Updates specified availability
  • Adds note on options that are now compatible with row_conditions

After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.

For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.

In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g. closes #123).

Previous Design Review notes:

Definition of Done

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation

Thank you for submitting!

Rachel-Reverie and others added 2 commits May 18, 2022 10:12
-Added note on options that are now compatible with `row_conditions`
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit be20f25
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/628e89c11f8b0d00087fc4bb
😎 Deploy Preview https://deploy-preview-5150--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label May 18, 2022
- Some edits to text to support the above corrections.
- Minor edits to text for better readability
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this @Rachel-Reverie. LGTM

@Rachel-Reverie Rachel-Reverie enabled auto-merge (squash) May 25, 2022 19:55
@Rachel-Reverie Rachel-Reverie merged commit 4e5e766 into develop May 25, 2022
@Rachel-Reverie Rachel-Reverie deleted the DOCS/DOC-248/update_availability_of_conditional_expectations branch May 25, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants