Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] remove account id deprecation notice #5158

Merged
merged 2 commits into from
May 19, 2022
Merged

[MAINTENANCE] remove account id deprecation notice #5158

merged 2 commits into from
May 19, 2022

Conversation

dctalbot
Copy link
Contributor

Changes proposed in this pull request:

  • remove a deprecation warning

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented May 18, 2022 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 2634263
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62864290b6a1f0000855bd4a
😎 Deploy Preview https://deploy-preview-5158--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Shinnnyshinshin
Copy link
Contributor

Hi @dctalbot looks great to me, but it looks like you'll have to sign the CLA before you can merge.

https://docs.greatexpectations.io/docs/contributing/contributing_misc

Shinnnyshinshin
Shinnnyshinshin approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving for when the CLA is signed :)

@dctalbot
Copy link
Contributor Author

@cla-bot check

@cdkini cdkini enabled auto-merge (squash) May 19, 2022 13:14
@cdkini cdkini merged commit c5bc621 into develop May 19, 2022
@cdkini cdkini deleted the maintenance/rm-dep-warning branch May 19, 2022 13:57
Shinnnyshinshin pushed a commit that referenced this pull request May 19, 2022
Merge branch 'feature/GREAT-908/helper-method-to-identify-self-initia…
9b997ae 
…lizing' into feature/GREAT-693/notebook-self-initializing-expectations

* feature/GREAT-908/helper-method-to-identify-self-initializing:
  move the code to Expectation
  remove account id deprecation notices (#5158)
  [MAINTENANCE] Speed up the site builder (#5125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinnnyshinshin Shinnnyshinshin Shinnnyshinshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dctalbot @Shinnnyshinshin @cdkini