[MAINTENANCE] Initial Dockerfile for running tests and associated README. #5541
Conversation
❌ Deploy Preview for niobium-lead-7998 failed.
|
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| These commands will hopefully be scripted but they are presented here for the time being. These commands **require** | ||
| they are invoked in the root directory of this repo. |
There was a problem hiding this comment.
Might make a good invoke task.
docker/Dockerfile.tests
Outdated
| WORKDIR /great_expectations | ||
|
|
||
| FROM build_${SOURCE} AS dev | ||
| RUN pip install --requirement requirements.txt --requirement requirements-dev.txt \ |
There was a problem hiding this comment.
You should be able to just install the requirements-dev.txt file since that references all the other files that are explicitly listed
There was a problem hiding this comment.
Thanks for pointing this out! I was following what we currently do in the azure-pipelines.yml file but hadn't looked to closely at the contents of these requirement files. I'll give them a look and update. Thanks!
|
@alexsherstinsky I'm going to write up a document of my plan and steps going forward this morning. The main motivation of the current work is to get a reproducible image that will run in CI. I don't believe we'll need to stand up other services for this work so I don't think I'll be creating a docker-compose file. I would like to get a fully functional system locally though so we'll see if that gets prioritized after this initial work is done. |
This creates a dockerfile that builds an image with Great Expectations and installs the dependencies. The plan is to use this as a reproducible environment for testing. Currently the tests do not pass when run on the container but that issue is with the tests vs the construction of the image. Follow up PRs will address these tests as well as integrating it into our CI pipeline.
This is for GREAT-1048
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!