Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Misc updates to Datasource CRUD on DataContext to ensure consistent behavior #5584

Merged
merged 8 commits into from
Jul 26, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Jul 25, 2022

Changes proposed in this pull request:

  • delete_datasource should only persist changes on the DataContext and must be opt-in on the BaseDataContext
  • update_datasource should always update the config and cache (but only conditionally persist changes based on the save mechanism as stated above).

Definition of Done

Please delete options that are not relevant.

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 85089e0
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62df32b017d3de0008413d7d
😎 Deploy Preview https://deploy-preview-5584--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jul 25, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@cdkini cdkini self-assigned this Jul 25, 2022
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdkini cdkini enabled auto-merge (squash) July 25, 2022 20:43
@cdkini cdkini merged commit 9f05d5e into develop Jul 26, 2022
@cdkini cdkini deleted the maintenance/misc-updates-to-datasource-crud branch July 26, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants