-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Misc updates to Datasource
CRUD on DataContext
to ensure consistent behavior
#5584
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…_expectations into maintenance/misc-updates-to-datasource-crud
Changes proposed in this pull request:
delete_datasource
should only persist changes on theDataContext
and must be opt-in on theBaseDataContext
update_datasource
should always update the config and cache (but only conditionally persist changes based on the save mechanism as stated above).Definition of Done
Please delete options that are not relevant.